Skip to content

Commit eff897a

Browse files
phil-davisphil-davis
authored
Merge pull request #33125 from owncloud/acceptance-test-tag-public_link_share
Acceptance test tag public link share
2 parents 438615a + a90a780 commit eff897a

File tree

14 files changed

+63
-55
lines changed

14 files changed

+63
-55
lines changed

‎tests/acceptance/features/apiCapabilities/capabilities.feature‎

Lines changed: 10 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,17 @@ Feature: capabilities
5656
| files_sharing | user_enumeration@@@enabled | 1 |
5757
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
5858
| files | bigfilechunking | 1 |
59+
60+
@files_trashbin-app-required
61+
Scenario: getting trashbin app capability with admin user
62+
When the administrator retrieves the capabilities using the capabilities API
63+
Then the capabilities should contain
5964
| files | undelete | 1 |
65+
66+
@files_versions-app-required
67+
Scenario: getting versions app capability with admin user
68+
When the administrator retrieves the capabilities using the capabilities API
69+
Then the capabilities should contain
6070
| files | versioning | 1 |
6171

6272
Scenario: Changing public upload
@@ -80,8 +90,6 @@ Feature: capabilities
8090
| files_sharing | user_enumeration@@@enabled | 1 |
8191
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
8292
| files | bigfilechunking | 1 |
83-
| files | undelete | 1 |
84-
| files | versioning | 1 |
8593

8694
Scenario: Disabling share api
8795
Given parameter "shareapi_enabled" of app "core" has been set to "no"
@@ -98,8 +106,6 @@ Feature: capabilities
98106
| files_sharing | federation@@@outgoing | 1 |
99107
| files_sharing | federation@@@incoming | 1 |
100108
| files | bigfilechunking | 1 |
101-
| files | undelete | 1 |
102-
| files | versioning | 1 |
103109

104110
Scenario: Disabling public links
105111
Given parameter "shareapi_allow_links" of app "core" has been set to "no"
@@ -120,8 +126,6 @@ Feature: capabilities
120126
| files_sharing | user_enumeration@@@enabled | 1 |
121127
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
122128
| files | bigfilechunking | 1 |
123-
| files | undelete | 1 |
124-
| files | versioning | 1 |
125129

126130
Scenario: Changing resharing
127131
Given parameter "shareapi_allow_resharing" of app "core" has been set to "no"
@@ -144,8 +148,6 @@ Feature: capabilities
144148
| files_sharing | user_enumeration@@@enabled | 1 |
145149
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
146150
| files | bigfilechunking | 1 |
147-
| files | undelete | 1 |
148-
| files | versioning | 1 |
149151

150152
Scenario: Changing federation outgoing
151153
Given parameter "outgoing_server2server_share_enabled" of app "files_sharing" has been set to "no"
@@ -168,8 +170,6 @@ Feature: capabilities
168170
| files_sharing | user_enumeration@@@enabled | 1 |
169171
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
170172
| files | bigfilechunking | 1 |
171-
| files | undelete | 1 |
172-
| files | versioning | 1 |
173173

174174
Scenario: Changing federation incoming
175175
Given parameter "incoming_server2server_share_enabled" of app "files_sharing" has been set to "no"
@@ -192,8 +192,6 @@ Feature: capabilities
192192
| files_sharing | user_enumeration@@@enabled | 1 |
193193
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
194194
| files | bigfilechunking | 1 |
195-
| files | undelete | 1 |
196-
| files | versioning | 1 |
197195

198196
Scenario: Changing "password enforced for read-only public link shares"
199197
Given parameter "shareapi_enforce_links_password_read_only" of app "core" has been set to "yes"
@@ -219,8 +217,6 @@ Feature: capabilities
219217
| files_sharing | user_enumeration@@@enabled | 1 |
220218
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
221219
| files | bigfilechunking | 1 |
222-
| files | undelete | 1 |
223-
| files | versioning | 1 |
224220

225221
Scenario: Changing "password enforced for read-write public link shares"
226222
Given parameter "shareapi_enforce_links_password_read_write" of app "core" has been set to "yes"
@@ -246,8 +242,6 @@ Feature: capabilities
246242
| files_sharing | user_enumeration@@@enabled | 1 |
247243
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
248244
| files | bigfilechunking | 1 |
249-
| files | undelete | 1 |
250-
| files | versioning | 1 |
251245

252246
Scenario: Changing "password enforced for write-only public link shares"
253247
Given parameter "shareapi_enforce_links_password_write_only" of app "core" has been set to "yes"
@@ -273,8 +267,6 @@ Feature: capabilities
273267
| files_sharing | user_enumeration@@@enabled | 1 |
274268
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
275269
| files | bigfilechunking | 1 |
276-
| files | undelete | 1 |
277-
| files | versioning | 1 |
278270

279271
Scenario: Changing public notifications
280272
Given parameter "shareapi_allow_public_notification" of app "core" has been set to "yes"
@@ -297,8 +289,6 @@ Feature: capabilities
297289
| files_sharing | user_enumeration@@@enabled | 1 |
298290
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
299291
| files | bigfilechunking | 1 |
300-
| files | undelete | 1 |
301-
| files | versioning | 1 |
302292

303293
Scenario: Changing public social share
304294
Given parameter "shareapi_allow_social_share" of app "core" has been set to "no"
@@ -321,8 +311,6 @@ Feature: capabilities
321311
| files_sharing | user_enumeration@@@enabled | 1 |
322312
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
323313
| files | bigfilechunking | 1 |
324-
| files | undelete | 1 |
325-
| files | versioning | 1 |
326314

327315
Scenario: Changing expire date
328316
Given parameter "shareapi_default_expire_date" of app "core" has been set to "yes"
@@ -346,8 +334,6 @@ Feature: capabilities
346334
| files_sharing | user_enumeration@@@enabled | 1 |
347335
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
348336
| files | bigfilechunking | 1 |
349-
| files | undelete | 1 |
350-
| files | versioning | 1 |
351337

352338
Scenario: Changing expire date enforcing
353339
Given parameter "shareapi_default_expire_date" of app "core" has been set to "yes"
@@ -373,8 +359,6 @@ Feature: capabilities
373359
| files_sharing | user_enumeration@@@enabled | 1 |
374360
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
375361
| files | bigfilechunking | 1 |
376-
| files | undelete | 1 |
377-
| files | versioning | 1 |
378362

379363
Scenario: Changing group sharing allowed
380364
Given parameter "shareapi_allow_group_sharing" of app "core" has been set to "no"
@@ -397,8 +381,6 @@ Feature: capabilities
397381
| files_sharing | user_enumeration@@@enabled | 1 |
398382
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
399383
| files | bigfilechunking | 1 |
400-
| files | undelete | 1 |
401-
| files | versioning | 1 |
402384

403385
Scenario: Changing only share with group member
404386
Given parameter "shareapi_only_share_with_group_members" of app "core" has been set to "yes"
@@ -421,8 +403,6 @@ Feature: capabilities
421403
| files_sharing | user_enumeration@@@enabled | 1 |
422404
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
423405
| files | bigfilechunking | 1 |
424-
| files | undelete | 1 |
425-
| files | versioning | 1 |
426406

427407
Scenario: Changing allow share dialog user enumeration
428408
Given parameter "shareapi_allow_share_dialog_user_enumeration" of app "core" has been set to "no"
@@ -444,8 +424,6 @@ Feature: capabilities
444424
| files_sharing | share_with_group_members_only | EMPTY |
445425
| files_sharing | user_enumeration@@@enabled | EMPTY |
446426
| files | bigfilechunking | 1 |
447-
| files | undelete | 1 |
448-
| files | versioning | 1 |
449427

450428
Scenario: Changing allow share dialog user enumeration for group members only
451429
Given parameter "shareapi_share_dialog_user_enumeration_group_members" of app "core" has been set to "yes"
@@ -468,8 +446,6 @@ Feature: capabilities
468446
| files_sharing | user_enumeration@@@enabled | 1 |
469447
| files_sharing | user_enumeration@@@group_members_only | 1 |
470448
| files | bigfilechunking | 1 |
471-
| files | undelete | 1 |
472-
| files | versioning | 1 |
473449

474450
Scenario: Changing exclude groups from sharing
475451
Given parameter "shareapi_exclude_groups" of app "core" has been set to "yes"
@@ -496,8 +472,6 @@ Feature: capabilities
496472
| files_sharing | user_enumeration@@@enabled | 1 |
497473
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
498474
| files | bigfilechunking | 1 |
499-
| files | undelete | 1 |
500-
| files | versioning | 1 |
501475

502476
Scenario: When in a group that is excluded from sharing, can_share is off
503477
Given parameter "shareapi_exclude_groups" of app "core" has been set to "yes"
@@ -527,8 +501,6 @@ Feature: capabilities
527501
| files_sharing | user_enumeration@@@enabled | 1 |
528502
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
529503
| files | bigfilechunking | 1 |
530-
| files | undelete | 1 |
531-
| files | versioning | 1 |
532504

533505
Scenario: When not in any group that is excluded from sharing, can_share is on
534506
Given parameter "shareapi_exclude_groups" of app "core" has been set to "yes"
@@ -558,8 +530,6 @@ Feature: capabilities
558530
| files_sharing | user_enumeration@@@enabled | 1 |
559531
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
560532
| files | bigfilechunking | 1 |
561-
| files | undelete | 1 |
562-
| files | versioning | 1 |
563533

564534
Scenario: When in a group that is excluded from sharing and in another group, can_share is off
565535
Given parameter "shareapi_exclude_groups" of app "core" has been set to "yes"
@@ -590,5 +560,3 @@ Feature: capabilities
590560
| files_sharing | user_enumeration@@@enabled | 1 |
591561
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
592562
| files | bigfilechunking | 1 |
593-
| files | undelete | 1 |
594-
| files | versioning | 1 |

‎tests/acceptance/features/apiMain/external-storage.feature‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ Feature: external-storage
55
Given using OCS API version "1"
66
And using old DAV path
77

8-
Scenario: Share by link a file inside a local external storage
8+
@public_link_share-feature-required
9+
Scenario: Share by public link a file inside a local external storage
910
Given user "user0" has been created
1011
And user "user1" has been created
1112
And user "user0" has created a folder "/local_storage/foo"

‎tests/acceptance/features/apiMain/transfer-ownership.feature‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ Feature: transfer-ownership
178178
Then the command should have been successful
179179
And the downloaded content when downloading file "/somefile.txt" for user "user2" with range "bytes=0-6" should be "This is"
180180

181-
@skipOnEncryptionType:user-keys
181+
@skipOnEncryptionType:user-keys @public_link_share-feature-required
182182
Scenario: transferring ownership of folder shares which has public link
183183
Given user "user0" has been created
184184
And user "user1" has been created
@@ -245,7 +245,7 @@ Feature: transfer-ownership
245245
And using received transfer folder of "user1" as dav path
246246
And as "user1" the folder "/sub/test" should not exist
247247

248-
@skipOnEncryptionType:user-keys
248+
@skipOnEncryptionType:user-keys @public_link_share-feature-required
249249
Scenario: transferring ownership of folder shared with transfer recipient and public link created of received share works
250250
Given user "user0" has been created
251251
And user "user1" has been created

‎tests/acceptance/features/apiShareManagement/createShare.feature‎

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ Feature: sharing
6767
| 1 | 100 |
6868
| 2 | 200 |
6969

70+
@public_link_share-feature-required
7071
Scenario Outline: Creating a new public link share of a file
7172
Given using OCS API version "<ocs_api_version>"
7273
When user "user0" creates a public link share using the sharing API with settings
@@ -79,7 +80,7 @@ Feature: sharing
7980
| 1 | 100 |
8081
| 2 | 200 |
8182

82-
@smokeTest
83+
@smokeTest @public_link_share-feature-required
8384
Scenario Outline: Creating a new public link share of a file with password
8485
Given using OCS API version "<ocs_api_version>"
8586
When user "user0" creates a public link share using the sharing API with settings
@@ -93,6 +94,7 @@ Feature: sharing
9394
| 1 | 100 |
9495
| 2 | 200 |
9596

97+
@public_link_share-feature-required
9698
Scenario Outline: Trying to create a new public link share of a file with edit permissions results in a read-only share
9799
Given using OCS API version "<ocs_api_version>"
98100
When user "user0" creates a public link share using the sharing API with settings
@@ -113,6 +115,7 @@ Feature: sharing
113115
| 1 | 100 |
114116
| 2 | 200 |
115117

118+
@public_link_share-feature-required
116119
Scenario Outline: Creating a new public link share of a folder
117120
Given using OCS API version "<ocs_api_version>"
118121
When user "user0" creates a public link share using the sharing API with settings
@@ -152,6 +155,7 @@ Feature: sharing
152155
Then the OCS status code should be "401"
153156
And the HTTP status code should be "401"
154157

158+
@public_link_share-feature-required
155159
Scenario Outline: Creating a link share with no specified permissions defaults to read permissions
156160
Given using OCS API version "<ocs_api_version>"
157161
And user "user0" has created a folder "/afolder"
@@ -168,6 +172,7 @@ Feature: sharing
168172
| 1 | 100 |
169173
| 2 | 200 |
170174

175+
@public_link_share-feature-required
171176
Scenario Outline: Creating a link share with no specified permissions defaults to read permissions when public upload disabled globally
172177
Given using OCS API version "<ocs_api_version>"
173178
And parameter "shareapi_allow_public_upload" of app "core" has been set to "no"
@@ -185,6 +190,7 @@ Feature: sharing
185190
| 1 | 100 |
186191
| 2 | 200 |
187192

193+
@public_link_share-feature-required
188194
Scenario Outline: Creating a link share with edit permissions keeps it
189195
Given using OCS API version "<ocs_api_version>"
190196
And user "user0" has created a folder "/afolder"
@@ -254,6 +260,7 @@ Feature: sharing
254260
| 1 | 100 |
255261
| 2 | 200 |
256262

263+
@public_link_share-feature-required
257264
Scenario Outline: Do not allow public sharing of the root
258265
Given using OCS API version "<ocs_api_version>"
259266
When user "user0" creates a public link share using the sharing API with settings
@@ -264,6 +271,7 @@ Feature: sharing
264271
| 1 | 403 |
265272
| 2 | 403 |
266273

274+
@public_link_share-feature-required
267275
Scenario: Only allow 1 link share per file/folder
268276
Given using OCS API version "1"
269277
And as user "user0"
@@ -444,7 +452,8 @@ Feature: sharing
444452
| 1 | 100 |
445453
| 2 | 200 |
446454

447-
Scenario Outline: user creates a public link share of a file with file name longer than 64 chars
455+
@public_link_share-feature-required
456+
Scenario Outline: user creates a public link share of a file with file name longer than 64 chars
448457
Given using OCS API version "<ocs_api_version>"
449458
And user "user0" has moved file "welcome.txt" to "aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog.txt"
450459
When user "user0" creates a public link share using the sharing API with settings
@@ -457,7 +466,8 @@ Scenario Outline: user creates a public link share of a file with file name long
457466
| 1 | 100 |
458467
| 2 | 200 |
459468

460-
Scenario Outline: user creates a public link share of a folder with folder name longer than 64 chars
469+
@public_link_share-feature-required
470+
Scenario Outline: user creates a public link share of a folder with folder name longer than 64 chars
461471
Given using OCS API version "<ocs_api_version>"
462472
And user "user0" has created a folder "/aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog"
463473
And user "user0" has moved file "welcome.txt" to "aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog/welcome.txt"

‎tests/acceptance/features/apiShareManagement/multilinksharing.feature‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@api @TestAlsoOnExternalUserBackend
1+
@api @TestAlsoOnExternalUserBackend @public_link_share-feature-required
22
Feature: multilinksharing
33

44
Background:

0 commit comments

Comments
 (0)