Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple bugs reported on oc.org #177

Open
hurradieweltgehtunter opened this issue Jan 6, 2020 · 3 comments
Open

Multiple bugs reported on oc.org #177

hurradieweltgehtunter opened this issue Jan 6, 2020 · 3 comments

Comments

@hurradieweltgehtunter
Copy link

There are multiple bug reports on owncloud.org in the comments: https://owncloud.org/news/good-bye-gallery-say-hi-to-the-new-media-viewer/

Could someone look into that?

@hurradieweltgehtunter hurradieweltgehtunter changed the title Multiple bug reported on oc.org Multiple bugs reported on oc.org Jan 6, 2020
@jnweiger
Copy link
Contributor

jnweiger commented Jan 7, 2020

The comments basically revolve around one "Bug": There is no view that shows multiple tiled previews (aka Album-View, Grid-View or Gallery-View). Thus it does not replace the gallery app.

Related issues:

@hurradieweltgehtunter
Copy link
Author

Also:
"With the new player 90% of my videos dont work anymore (*.avi / *.mkv), while they worked fine on the old one. The old had a volume regulator wich the new one doesnt. Why would someone replace a very good working plugin with this not even half ready player?"

@RossRogers
Copy link
Contributor

I think somewhat related, I'm seeing an issue on the chrome client javascript console with the latest release and the latest file_mediaviewer plugin:

files_mediaviewer_init.js?v=8eceae50c86a607ec9f9d975d41788c4:formatted:99 Uncaught TypeError: Cannot read property 'registerAction' of undefined
    at files_mediaviewer_init.js?v=8eceae50c86a607ec9f9d975d41788c4:formatted:99
    at Array.forEach (<anonymous>)
    at HTMLDocument.<anonymous> (files_mediaviewer_init.js?v=8eceae50c86a607ec9f9d975d41788c4:formatted:92)
    at j (jquery.js:3099)
    at Object.fireWith [as resolveWith] (jquery.js:3211)
    at Function.ready (jquery.js:3417)
    at HTMLDocument.I (jquery.js:3433)

It is failing on these lines:

OCA.Files.fileActions.registerAction(r),
OCA.Files.fileActions.setDefault(i, e.name)

If I wrap them in a try/catch, it runs, but I'm not sure what I'm now missing:

try {
    OCA.Files.fileActions.registerAction(r),
    OCA.Files.fileActions.setDefault(i, e.name)
} catch (e) {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants