Adjust code and add unit tests

Author: jvillafanez

lib/UserSyncLDAPBackend.php

@@ -40,6 +40,22 @@ public function __construct(User_Proxy $userProxy) {
 		$this->userProxy = $userProxy;
 	}
 
+	/**
+	 * Get the pointer's position. This method isn't part of the interface and
+	 * it's expected to be used only for testing
+	 */
+	public function getPointer() {
+		return $this->pointer;
+	}
+
+	/**
+	 * Get the cached user data. This method isn't part of the interface and
+	 * it's expected to be used only for testing
+	 */
+	public function getCachedUserData() {
+		return $this->cachedUserData;
+	}
+
 	/**
 	 * @inheritDoc
 	 */
@@ -97,7 +113,7 @@ public function getNextUser(): ?SyncingUser {
 				$email = $userEntry->getEMailAddress();
 				$home = $userEntry->getHome();
 				$searchTerms = $userEntry->getSearchTerms();
-			} catch (\Exception $e) {
+			} catch (\Exception $ex) {
 				throw new SyncBackendUserFailedException("Can't sync user with dn {$userEntry->getDN()}", 1, $ex);
 			}
 
@@ -141,7 +157,7 @@ public function getSyncingUser(string $id): ?SyncingUser {
 				$email = $userEntry->getEMailAddress();
 				$home = $userEntry->getHome();
 				$searchTerms = $userEntry->getSearchTerms();
-			} catch (\Exception $e) {
+			} catch (\Exception $ex) {
 				throw new SyncBackendUserFailedException("Can't sync user with dn {$userEntry->getDN()}", 1, $ex);
 			}
 

tests/unit/User/ManagerTest.php

@@ -330,6 +330,17 @@ public function testGetUsersSearchEmptyResult() {
 		$this->assertCount(0, $result);
 	}
 
+	public function testGetLdapUsers() {
+		$this->prepareForGetUsers();
+		$result = $this->manager->getLdapUsers('');
+		$expected = [
+			[ 'dn' => ['cn=alice,dc=foobar,dc=bar'] ],
+			[ 'dn' => ['cn=bob,dc=foobar,dc=bar'] ],
+			[ 'dn' => ['cn=carol,dc=foobar,dc=bar'] ],
+		];
+		$this->assertEquals($expected, $result);
+	}
+
 	public function testGetUserEntryByDn() {
 		$this->access->expects($this->once())
 			->method('executeRead')