Skip to content

Commit 01d6158

Browse files
committedJul 3, 2024·
remove ExternalLink component used in one spot
1 parent 00b7602 commit 01d6158

File tree

2 files changed

+5
-32
lines changed

2 files changed

+5
-32
lines changed
 

‎app/components/DocsPopover.tsx

+5-5
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,25 @@ import { OpenLink12Icon, Question12Icon } from '@oxide/design-system/icons/react
1313

1414
import { buttonStyle } from '~/ui/lib/Button'
1515

16-
import { ExternalLink } from './ExternalLink'
17-
1816
type DocsPopoverLinkProps = {
1917
href: string
2018
linkText: string
2119
}
2220

2321
export const DocsPopoverLink = ({ href, linkText }: DocsPopoverLinkProps) => (
24-
<ExternalLink
22+
<a
2523
href={href}
26-
className="group block px-4 no-underline children:last:border-0"
24+
className="group block px-4 children:last:border-0"
25+
target="_blank"
26+
rel="noreferrer"
2727
>
2828
<div className="mx-2 border-b py-1.5 border-secondary">
2929
<div className="relative -ml-2 inline-block rounded py-1 pl-2 pr-7 text-sans-md !text-default group-hover:bg-tertiary">
3030
<span className="inline-block max-w-[300px] truncate align-middle">{linkText}</span>
3131
<OpenLink12Icon className="absolute top-1.5 ml-2 translate-y-[1px] text-tertiary" />
3232
</div>
3333
</div>
34-
</ExternalLink>
34+
</a>
3535
)
3636

3737
type DocsPopoverProps = {

‎app/components/ExternalLink.tsx

-27
This file was deleted.

0 commit comments

Comments
 (0)
Please sign in to comment.