Skip to content

Commit 3474c6c

Browse files
Update z index for action menu dropdowns (#2522)
Co-authored-by: David Crespo <[email protected]>
1 parent af6a89e commit 3474c6c

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

app/components/TopBar.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export function TopBar({ children }: { children: React.ReactNode }) {
5555
</span>
5656
<DirectionDownIcon className="!w-2.5" />
5757
</DropdownMenu.Trigger>
58-
<DropdownMenu.Content gap={8} className="!z-topBarPopover">
58+
<DropdownMenu.Content gap={8}>
5959
<DropdownMenu.LinkItem to={pb.profile()}>Settings</DropdownMenu.LinkItem>
6060
<DropdownMenu.Item onSelect={() => logout.mutate({})}>
6161
Sign out

app/components/TopBarPicker.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ const TopBarPicker = (props: TopBarPickerProps) => {
112112
{/* TODO: popover position should be further right */}
113113
{props.items && (
114114
<DropdownMenu.Content
115-
className="!z-topBarPopover mt-2 max-h-80 min-w-[12.8125rem] overflow-y-auto"
115+
className="mt-2 max-h-80 min-w-[12.8125rem] overflow-y-auto"
116116
anchor="bottom start"
117117
>
118118
{props.items.length > 0 ? (

app/ui/styles/components/menu-button.css

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
*/
88

99
.DropdownMenuContent {
10-
@apply z-popover min-w-36 rounded border p-0 bg-raise border-secondary;
10+
/* we want menu popover to be on top of top bar and pagination bar too */
11+
@apply z-topBarDropdown min-w-36 rounded border p-0 bg-raise border-secondary;
1112

1213
& .DropdownMenuItem {
1314
@apply block w-full cursor-pointer select-none border-b py-2 pl-3 pr-6 text-left text-sans-md text-secondary border-secondary last:border-b-0;

tailwind.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ module.exports = {
4848
modal: '40',
4949
sideModalDropdown: '40',
5050
sideModal: '30',
51-
topBarPopover: '25',
51+
topBarDropdown: '25',
5252
topBar: '20',
5353
popover: '10',
5454
contentDropdown: '10',

0 commit comments

Comments
 (0)