Boot order (#2464)

* bump API for boot disk changes

* implement instance update endpoint

* show boot disk with badge in table

* add row actions

* instance create works good

* point at the actual omicron PR

* split instance disks into two tables

* move the disk buttons into the table headers

* fix one our most pointless e2es

* assert about boot disks after instance create

* add e2e test for instance create with more disks, test disk create

* move the buttons back under the tables

* take the button out, always disable detach for boot disk

* split frankenstein actions array into two, make e2e tests pass

* update omicron to latest commit on PR, fix breakage thereby introduced

* mock update errors out if boot disk is not attached

* update to a commit on omicron main

* cite omicron source for logic about when you can set a boot disk

* test for changing boot disk

* ixi's feedback, clean up mock API logic

* moderately deranged boot disk empty state copy

* tweak empty state copy and assert about it in e2e test

* clean up copy TODOs in confirm modals

* bump API to latest dogfood version (only doc comment changes)

* rename disks to otherDisks, existing disk test looks at boot vs. other

Author: david-crespo

OMICRON_VERSION

@@ -1 +1 @@
-d2e3f344e82fd7a1f45a39a9d1f867f9238d171d
+c50cf019cd9be35f98266a7f4acacab0236b3a3d

app/api/__generated__/Api.ts

@@ -90,12 +90,18 @@ export const genName = (...parts: [string, ...string[]]) => {
 }
 
 const instanceActions: Record<string, InstanceState[]> = {
+  // NoVmm maps to to Stopped:
+  // https://github.com/oxidecomputer/omicron/blob/6dd9802/nexus/db-model/src/instance_state.rs#L55
+
   // https://github.com/oxidecomputer/omicron/blob/0496637/nexus/src/app/instance.rs#L2064
   start: ['stopped', 'failed'],
 
   // https://github.com/oxidecomputer/omicron/blob/6dd9802/nexus/db-queries/src/db/datastore/instance.rs#L865
   delete: ['stopped', 'failed'],
 
+  // https://github.com/oxidecomputer/omicron/blob/3093818/nexus/db-queries/src/db/datastore/instance.rs#L1030-L1043
+  update: ['stopped', 'failed', 'creating'],
+
   // reboot and stop are kind of weird!
   // https://github.com/oxidecomputer/omicron/blob/6dd9802/nexus/src/app/instance.rs#L790-L798
   // https://github.com/oxidecomputer/propolis/blob/b278193/bin/propolis-server/src/lib/vm/request_queue.rs
@@ -104,9 +110,6 @@ const instanceActions: Record<string, InstanceState[]> = {
   // stopping a failed disk: https://github.com/oxidecomputer/omicron/blob/f0b804818b898bebdb317ac2b000618944c02457/nexus/src/app/instance.rs#L818-L830
   stop: ['running', 'starting', 'rebooting', 'failed'],
 
-  // NoVmm maps to to Stopped:
-  // https://github.com/oxidecomputer/omicron/blob/6dd9802/nexus/db-model/src/instance_state.rs#L55
-
   // https://github.com/oxidecomputer/omicron/blob/6dd9802/nexus/db-queries/src/db/datastore/disk.rs#L323-L327
   detachDisk: ['creating', 'stopped', 'failed'],
   // only Creating and NoVmm
@@ -149,6 +152,8 @@ const diskActions: Record<string, DiskState['state'][]> = {
   attach: ['creating', 'detached'],
   // https://github.com/oxidecomputer/omicron/blob/6dd9802/nexus/db-queries/src/db/datastore/disk.rs#L313-L314
   detach: ['attached'],
+  // https://github.com/oxidecomputer/omicron/blob/3093818/nexus/db-queries/src/db/datastore/instance.rs#L1077-L1081
+  setAsBootDisk: ['attached'],
 }
 
 export const diskCan = R.mapValues(diskActions, (states) => {

app/api/__generated__/OMICRON_VERSION

@@ -15,7 +15,6 @@ import { CreateDiskSideModalForm } from '~/forms/disk-create'
 import type { InstanceCreateInput } from '~/forms/instance-create'
 import { Badge } from '~/ui/lib/Badge'
 import { Button } from '~/ui/lib/Button'
-import { FieldLabel } from '~/ui/lib/FieldLabel'
 import * as MiniTable from '~/ui/lib/MiniTable'
 import { bytesToGiB } from '~/util/units'
 
@@ -39,14 +38,13 @@ export function DisksTableField({
 
   const {
     field: { value: items, onChange },
-  } = useController({ control, name: 'disks' })
+  } = useController({ control, name: 'otherDisks' })
 
   return (
     <>
       <div className="max-w-lg">
-        <FieldLabel id="new-disks-label">{/* this was empty */}</FieldLabel>
         {!!items.length && (
-          <MiniTable.Table className="mb-4">
+          <MiniTable.Table className="mb-4" aria-label="Disks">
             <MiniTable.Header>
               <MiniTable.HeadCell>Name</MiniTable.HeadCell>
               <MiniTable.HeadCell>Type</MiniTable.HeadCell>
@@ -68,7 +66,7 @@ export function DisksTableField({
                   </MiniTable.Cell>
                   <MiniTable.Cell>
                     {item.type === 'attach' ? (
-                      '-'
+                      '—'
                     ) : (
                       <>
                         <span>{bytesToGiB(item.size)}</span>

app/api/__generated__/msw-handlers.ts

@@ -103,7 +103,7 @@ export type InstanceCreateInput = Assign<
   SetRequired<InstanceCreate, 'networkInterfaces'>,
   {
     presetId: (typeof PRESETS)[number]['id']
-    disks: DiskTableItem[]
+    otherDisks: DiskTableItem[]
     bootDiskName: string
     bootDiskSize: number
 
@@ -139,7 +139,7 @@ const baseDefaultValues: InstanceCreateInput = {
   projectImageSource: '',
   diskSource: '',
 
-  disks: [],
+  otherDisks: [],
   networkInterfaces: { type: 'default' },
 
   sshPublicKeys: [],
@@ -316,7 +316,8 @@ export function CreateInstanceForm() {
               description: values.description,
               memory: instance.memory * GiB,
               ncpus: instance.ncpus,
-              disks: [bootDisk, ...values.disks],
+              disks: values.otherDisks,
+              bootDisk,
               externalIps: values.externalIps,
               start: values.start,
               networkInterfaces: values.networkInterfaces,