Add state and policy columns to physical disks table (#2151)

* add more data to disks table

* add decommissioned disk to list

* use neutral color for decommissioned / expunged badges

* reorder columns

* update test to include new policy and state columns

* more efficient expectations

Author: charliepark

app/pages/system/inventory/DisksTab.tsx

@@ -36,6 +36,20 @@ const staticCols = [
   }),
   colHelper.accessor('model', { header: 'model number' }),
   colHelper.accessor('serial', { header: 'serial number' }),
+  colHelper.accessor('policy', {
+    cell: (info) => {
+      const policy = info.getValue().kind
+      const color = policy === 'in_service' ? 'default' : 'neutral'
+      return <Badge color={color}>{policy.replace(/_/g, ' ')}</Badge>
+    },
+  }),
+  colHelper.accessor('state', {
+    cell: (info) => {
+      const state = info.getValue()
+      const color = state === 'active' ? 'default' : 'neutral'
+      return <Badge color={color}>{state}</Badge>
+    },
+  }),
 ]
 
 export function DisksTab() {

mock-api/physical-disk.ts

@@ -44,4 +44,20 @@ export const physicalDisks: Json<PhysicalDisk>[] = [
     form_factor: 'm2',
     serial: 'CA73ANUYLJ9',
   },
+  {
+    ...base,
+    id: '3a9f895a-e0da-4a1e-abf2-ce431d6c4c2e',
+    form_factor: 'm2',
+    serial: '7C15PW5D9N2',
+    policy: { kind: 'expunged' as const },
+    state: 'active' as const,
+  },
+  {
+    ...base,
+    id: 'ba1c3581-b35b-48a5-924a-cb19921dca54',
+    form_factor: 'm2',
+    serial: 'F02106C3R2A',
+    policy: { kind: 'expunged' as const },
+    state: 'decommissioned' as const,
+  },
 ]

test/e2e/inventory.e2e.ts

@@ -46,5 +46,20 @@ test('Disk inventory page', async ({ page }) => {
 
   const table = page.getByRole('table')
   await expectRowVisible(table, { id: physicalDisks[0].id, 'Form factor': 'U.2' })
-  await expectRowVisible(table, { id: physicalDisks[3].id, 'Form factor': 'M.2' })
+  await expectRowVisible(table, {
+    id: physicalDisks[3].id,
+    'Form factor': 'M.2',
+    policy: 'in service',
+    state: 'active',
+  })
+  await expectRowVisible(table, {
+    id: physicalDisks[4].id,
+    policy: 'expunged',
+    state: 'active',
+  })
+  await expectRowVisible(table, {
+    id: physicalDisks[5].id,
+    policy: 'expunged',
+    state: 'decommissioned',
+  })
 })