Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from AWS S3 to Github hosted build artificats #544

Open
fruffy opened this issue Feb 3, 2025 · 4 comments
Open

Move away from AWS S3 to Github hosted build artificats #544

fruffy opened this issue Feb 3, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@fruffy
Copy link
Contributor

fruffy commented Feb 3, 2025

Context of the discussion: #539 (comment)

@AdarshRawat1
Copy link
Member

The Setup for branches already exist, so maybe we can move forward with PR preview?

@jafingerhut
Copy link
Contributor

@AdarshRawat1 I have just read the comment at the link in the first comment of this issue.

If I understand correctly, the current state of this repo is that the CI is already committing PDF and HTML that is generated on every merge to main, and this is now visible on p4.org's specifications page. PDF and HTML are also being copied to a location on S3, and those are currently not used by p4.org, or as far as I know, by no one else.

Are you suggesting that someone creates a PR that stops copying the PDF and HTML to S3?

Or are you suggesting some other change should be made?

@AdarshRawat1
Copy link
Member

As mentioned by @fruffy sir, in this comment . I'm suggesting to add a PR preview system similar to what we have in P4C. Where reviewer can view the changes made by the PR as Live preview without actually building the website locally.

@fruffy
Copy link
Contributor Author

fruffy commented Feb 6, 2025

Are you suggesting that someone creates a PR that stops copying the PDF and HTML to S3?

That would be one of the outcomes, the other outcome is that we have a preview per PR for the P4Runtime spec PDF and markdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants