additional tests

Author: pachadotdev

R/helpers.R renamed to R/feglm_helpers.R

@@ -106,6 +106,8 @@ check_formula_ <- function(formula) {
 check_data_ <- function(data) {
   if (is.null(data)) {
     stop("'data' has to be specified.", call. = FALSE)
+  } else if (nrow(data) == 0L) {
+    stop("'data' has zero observations.", call. = FALSE)
   } else if (!inherits(data, "data.frame")) {
     stop("'data' has to be of class data.frame.", call. = FALSE)
   }

R/kendall_correlation.R

@@ -36,7 +36,7 @@ kendall_cor <- function(x, y) {
 
   n <- ncol(arr)
 
-  kw <- kendall_warnings(arr, n)
+  kw <- kendall_warnings_(arr, n)
 
   if (isFALSE(kw)) { return(NA) }
 
@@ -81,7 +81,7 @@ kendall_cor_test <- function(x, y,
   n <- nrow(arr)
   m <- ncol(arr)
 
-  kw <- kendall_warnings(arr, m)
+  kw <- kendall_warnings_(arr, m)
 
   if (isFALSE(kw)) { return(NA) }
 
@@ -138,7 +138,7 @@ kendall_cor_test <- function(x, y,
   )
 }
 
-kendall_warnings <- function(arr, n) {
+kendall_warnings_ <- function(arr, n) {
   if (n != 2) {
     stop("x and y must be uni-dimensional vectors")
   }

R/srr-stats-standards.R

@@ -58,13 +58,12 @@
 #' @srrstats {G5.4a} *For new methods, it can be difficult to separate out correctness of the method from the correctness of the implementation, as there may not be reference for comparison. In this case, testing may be implemented against simple, trivial cases or against multiple implementations such as an initial R implementation compared with results from a C/C++ implementation.*
 #' @srrstats {G5.4b} *For new implementations of existing methods, correctness tests should include tests against previous implementations. Such testing may explicitly call those implementations in testing, preferably from fixed-versions of other software, or use stored outputs from those where that is not possible.*
 #' @srrstats {G5.4c} *Where applicable, stored values may be drawn from published paper outputs when applicable and where code from original implementations is not available*
-#' @srrstatsTODO {G5.5} *Correctness tests should be run with a fixed random seed*
 #' @srrstatsTODO {G5.6} **Parameter recovery tests** *to test that the implementation produce expected results given data with known properties. For instance, a linear regression algorithm should return expected coefficient values for a simulated data set generated from a linear model.*
 #' @srrstatsTODO {G5.6a} *Parameter recovery tests should generally be expected to succeed within a defined tolerance rather than recovering exact values.*
 #' @srrstatsTODO {G5.6b} *Parameter recovery tests should be run with multiple random seeds when either data simulation or the algorithm contains a random component. (When long-running, such tests may be part of an extended, rather than regular, test suite; see G5.10-4.12, below).*
 #' @srrstatsTODO {G5.7} **Algorithm performance tests** *to test that implementation performs as expected as properties of data change. For instance, a test may show that parameters approach correct estimates within tolerance as data size increases, or that convergence times decrease for higher convergence thresholds.*
 #' @srrstatsTODO {G5.8} **Edge condition tests** *to test that these conditions produce expected behaviour such as clear warnings or errors when confronted with data with extreme properties including but not limited to:*
-#' @srrstatsTODO {G5.8a} *Zero-length data*
+#' @srrstats {G5.8a} *Zero-length data*
 #' @srrstats {G5.8b} *Data of unsupported types (e.g., character or complex numbers in for functions designed only for numeric data)*
 #' @srrstats {G5.8c} *Data with all-`NA` fields or columns or all identical fields or columns*
 #' @srrstats {G5.8d} *Data outside the scope of the algorithm (for example, data with more fields (columns) than observations (rows) for some regression algorithms)*
@@ -131,6 +130,7 @@ NULL
 #' to `@srrstatsNA`, and placed together in this block, along with explanations
 #' for why each of these standards have been deemed not applicable.
 #' (These comments may also be deleted at any time.)
+#' @srrstatsNA {G5.5} *Correctness tests should be run with a fixed random seed*
 #' @srrstatsNA {G2.14c} *replace missing data with appropriately imputed values*
 #' @srrstatsNA {G2.16} *All functions should also provide options to handle undefined values (e.g., `NaN`, `Inf` and `-Inf`), including potentially ignoring or removing such values.*
 #' @srrstatsNA {G5.11a} *When any downloads of additional data necessary for extended tests fail, the tests themselves should not fail, rather be skipped and implicitly succeed with an appropriate diagnostic message.*