Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit hook for ogr #287

Closed
2 tasks done
mfocko opened this issue Sep 27, 2024 · 0 comments · Fixed by #288
Closed
2 tasks done

pre-commit hook for ogr #287

mfocko opened this issue Sep 27, 2024 · 0 comments · Fixed by #288
Labels
area/other Related to some other area/category than the specified ones. complexity/single-task Regular task, should be done within days. kind/bug Something isn't working.

Comments

@mfocko
Copy link
Member

mfocko commented Sep 27, 2024

What happened? What is the problem?

During the fixing of packit/ogr#856 we have discovered that the requre pre-commit hook doesn't work as expected. Even when specifying --all-files or --file ‹path-to-the-file›, it skipped the file and didn't sanitize it.

Didn't even run in the Zuul, seems like an issue in the definition of the hook rather than requre itself (as it declares no files to be run on).

What did you expect to happen?

pre-commit hook working as it should…

Example URL(s)

https://softwarefactory-project.io/zuul/t/packit-service/build/6b0a1b1fe6a74738a06ea6217384801c/console

Steps to reproduce

1. Add/update/change the requre records
2. Run the CI
3. Observe unsanitized records

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@mfocko mfocko added the kind/bug Something isn't working. label Sep 27, 2024
@lbarcziova lbarcziova added area/other Related to some other area/category than the specified ones. complexity/single-task Regular task, should be done within days. labels Sep 30, 2024
@lbarcziova lbarcziova moved this from new to backlog in Packit Kanban Board Sep 30, 2024
@lbarcziova lbarcziova mentioned this issue Oct 23, 2024
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Oct 23, 2024
@softwarefactory-project-zuul
Fix files definition in hook config (#288)
41b9d29 
Fix files definition in hook config

Fixes #287

Reviewed-by: Matej Focko
@github-project-automation github-project-automation bot moved this from backlog to done in Packit Kanban Board Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/other Related to some other area/category than the specified ones. complexity/single-task Regular task, should be done within days. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix files definition in hook config lbarcziova/requre
2 participants
@mfocko @lbarcziova