Increase coverage

Author: paleite

jest.config.js

@@ -4,7 +4,7 @@ const { base } = require("@paleite/jest-config");
 /** @type {import('@jest/types').Config.InitialOptions} */
 module.exports = {
   ...base,
-  coveragePathIgnorePatterns: [".test-d.ts"],
+  coveragePathIgnorePatterns: [".test-d.ts", "/__fixtures__/"],
   coverageThreshold: {
     global: {
       statements: 80,

src/git.test.ts

@@ -66,6 +66,46 @@ describe("getDiffForFile", () => {
     expect(diffFromFile).toContain("diff --git");
     expect(diffFromFile).toContain("@@");
   });
+
+  it("should work when using staged = false", () => {
+    mockedChildProcess.execFileSync.mockReturnValueOnce(Buffer.from(hunks));
+    process.env.ESLINT_PLUGIN_DIFF_COMMIT = "1234567";
+
+    const diffFromFile = getDiffForFile("./mockfile.js", false);
+
+    const expectedCommand = "git";
+    const expectedArgs =
+      "diff --diff-algorithm=histogram --diff-filter=ACM --find-renames=100% --no-ext-diff --relative --unified=0 1234567";
+
+    const lastCall = mockedChildProcess.execFileSync.mock.calls.at(-1);
+    const [command, argsIncludingFile = []] = lastCall ?? [""];
+    const args = argsIncludingFile.slice(0, -2);
+
+    expect(command).toBe(expectedCommand);
+    expect(args.join(" ")).toEqual(expectedArgs);
+    expect(diffFromFile).toContain("diff --git");
+    expect(diffFromFile).toContain("@@");
+  });
+
+  it("should use HEAD when no commit was defined", () => {
+    mockedChildProcess.execFileSync.mockReturnValueOnce(Buffer.from(hunks));
+    process.env.ESLINT_PLUGIN_DIFF_COMMIT = undefined;
+
+    const diffFromFile = getDiffForFile("./mockfile.js", false);
+
+    const expectedCommand = "git";
+    const expectedArgs =
+      "diff --diff-algorithm=histogram --diff-filter=ACM --find-renames=100% --no-ext-diff --relative --unified=0 HEAD";
+
+    const lastCall = mockedChildProcess.execFileSync.mock.calls.at(-1);
+    const [command, argsIncludingFile = []] = lastCall ?? [""];
+    const args = argsIncludingFile.slice(0, -2);
+
+    expect(command).toBe(expectedCommand);
+    expect(args.join(" ")).toEqual(expectedArgs);
+    expect(diffFromFile).toContain("diff --git");
+    expect(diffFromFile).toContain("@@");
+  });
 });
 
 describe("hasCleanIndex", () => {
@@ -93,7 +133,7 @@ describe("getDiffFileList", () => {
       Buffer.from(diffFileList)
     );
     expect(mockedChildProcess.execFileSync).toHaveBeenCalledTimes(0);
-    const fileListA = getDiffFileList();
+    const fileListA = getDiffFileList(false);
 
     expect(mockedChildProcess.execFileSync).toHaveBeenCalledTimes(1);
     expect(fileListA).toEqual(
@@ -109,7 +149,7 @@ describe("getUntrackedFileList", () => {
       Buffer.from(diffFileList)
     );
     expect(mockedChildProcess.execFileSync).toHaveBeenCalledTimes(0);
-    const fileListA = getUntrackedFileList();
+    const fileListA = getUntrackedFileList(false);
     expect(mockedChildProcess.execFileSync).toHaveBeenCalledTimes(1);
 
     mockedChildProcess.execFileSync.mockReturnValueOnce(

src/git.ts

@@ -5,7 +5,7 @@ import { Range } from "./Range";
 const COMMAND = "git";
 const OPTIONS = { maxBuffer: 1024 * 1024 * 100 };
 
-const getDiffForFile = (filePath: string, staged = false): string => {
+const getDiffForFile = (filePath: string, staged: boolean): string => {
   const args = [
     "diff",
     "--diff-algorithm=histogram",
@@ -26,7 +26,7 @@ const getDiffForFile = (filePath: string, staged = false): string => {
   return child_process.execFileSync(COMMAND, args, OPTIONS).toString();
 };
 
-const getDiffFileList = (staged = false): string[] => {
+const getDiffFileList = (staged: boolean): string[] => {
   const args = [
     "diff",
     "--diff-algorithm=histogram",
@@ -79,7 +79,7 @@ const fetchFromOrigin = (branch: string) => {
 
 let untrackedFileListCache: string[] | undefined;
 const getUntrackedFileList = (
-  staged = false,
+  staged: boolean,
   shouldRefresh = false
 ): string[] => {
   if (staged) {

src/processors.ts

@@ -72,7 +72,7 @@ const getUnstagedChangesError = (filename: string): [Linter.LintMessage] => {
 };
 
 const getPostProcessor =
-  (staged = false) =>
+  (staged: boolean) =>
   (
     messages: Linter.LintMessage[][],
     filename: string