Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from flask-babelex to flask-babel #2165

Closed
demetrius-mp opened this issue Oct 23, 2021 · 3 comments
Closed

Move from flask-babelex to flask-babel #2165

demetrius-mp opened this issue Oct 23, 2021 · 3 comments

Comments

@demetrius-mp
Copy link

Since flask-babelex is discontinued, it would be great to add support for flask-babel instead of babelex in flask admin.

@gunlinux
Copy link
Contributor

Started to work with migration, got some issue with testing and app context

@LeXofLeviafan
Copy link
Contributor

Related items:

Additionally, there's currently a bug which prevents flask-admin (the latest PyPI package) from working with flask-babelex when flask-babel is installed: trying to open an entry edit form results in AttributeError: 'Babel' object has no attribute 'locale_selector' (wtforms imports flask_wtf that uses flask_babel, which clearly picks up the instance produced by flask-babelex and fails to use it because it relies on a decorator to specify the locale-selector instead of a keyword argument). And yes, it works when flask-babel is not installed due to how flask-wtf handles it.

…When's the next release anyway? The latest version on PyPI is 1.6.0 which is over a year old by now, and it doesn't include flask-babel fallback support (since it was added merely half a year ago).

@samuelhwilliams
Copy link
Contributor

This has been done by #2447 now - will be released in v2.0.0 🙏

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants