Skip to content

Commit bdd0946

Browse files
authored
type align (#1138)
* type align * prefer Scalar | NAType | None
1 parent e6bf5b2 commit bdd0946

File tree

4 files changed

+16
-10
lines changed

4 files changed

+16
-10
lines changed

Diff for: pandas-stubs/core/frame.pyi

+1-5
Original file line numberDiff line numberDiff line change
@@ -732,11 +732,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
732732
axis: Axis | None = ...,
733733
level: Level | None = ...,
734734
copy: _bool = ...,
735-
fill_value=...,
736-
method: FillnaOptions | None = ...,
737-
limit: int | None = ...,
738-
fill_axis: Axis = ...,
739-
broadcast_axis: Axis | None = ...,
735+
fill_value: Scalar | NAType | None = ...,
740736
) -> tuple[Self, NDFrameT]: ...
741737
def reindex(
742738
self,

Diff for: pandas-stubs/core/series.pyi

+1-5
Original file line numberDiff line numberDiff line change
@@ -1034,11 +1034,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
10341034
axis: Axis | None = ...,
10351035
level: Level | None = ...,
10361036
copy: _bool = ...,
1037-
fill_value=...,
1038-
method: FillnaOptions | None = ...,
1039-
limit: int | None = ...,
1040-
fill_axis: AxisIndex = ...,
1041-
broadcast_axis: AxisIndex | None = ...,
1037+
fill_value: Scalar | NAType | None = ...,
10421038
) -> tuple[Series, Series]: ...
10431039
@overload
10441040
def rename(

Diff for: tests/test_frame.py

+3
Original file line numberDiff line numberDiff line change
@@ -3662,6 +3662,9 @@ def test_align() -> None:
36623662
aligned_df0, aligned_s0 = df0.align(s0, axis="index")
36633663
check(assert_type(aligned_df0, pd.DataFrame), pd.DataFrame)
36643664
check(assert_type(aligned_s0, "pd.Series[str]"), pd.Series, str)
3665+
aligned_df0, aligned_s0 = df0.align(s0, axis="index", fill_value=0)
3666+
check(assert_type(aligned_df0, pd.DataFrame), pd.DataFrame)
3667+
check(assert_type(aligned_s0, "pd.Series[str]"), pd.Series, str)
36653668

36663669
s1 = pd.Series(data={"A": "A", "D": "D"})
36673670
aligned_df0, aligned_s1 = df0.align(s1, axis="columns")

Diff for: tests/test_series.py

+11
Original file line numberDiff line numberDiff line change
@@ -3672,3 +3672,14 @@ def test_info() -> None:
36723672
check(assert_type(s.info(show_counts=True), None), type(None))
36733673
check(assert_type(s.info(show_counts=False), None), type(None))
36743674
check(assert_type(s.info(show_counts=None), None), type(None))
3675+
3676+
3677+
def test_align() -> None:
3678+
s0 = pd.Series(data={0: 1, 3: 3, 5: 5})
3679+
s1 = pd.Series(data={0: 1, 2: 2})
3680+
aligned_s0, aligned_s1 = s0.align(s1)
3681+
check(assert_type(aligned_s0, pd.Series), pd.Series)
3682+
check(assert_type(aligned_s1, pd.Series), pd.Series)
3683+
aligned_s0, aligned_s1 = s0.align(s1, fill_value=0, axis=0, level=0, copy=False)
3684+
check(assert_type(aligned_s0, pd.Series), pd.Series)
3685+
check(assert_type(aligned_s1, pd.Series), pd.Series)

0 commit comments

Comments
 (0)