Clean up pylint rules

Author: tqa236

pyproject.toml

@@ -319,47 +319,26 @@ ignore = [
   "RUF007",
   # mutable-class-default
   "RUF012",
-  # Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
-  # "E721",
-  # Parenthesize `a and b` expressions when chaining `and` and `or` together, to make the precedence clear
-  "RUF021",
-  # `__all__` is not sorted
-  "RUF022",
-  # Use a `set` literal when testing for membership
-  "PLR6201",
+
+  # Additional pylint rules
+  # literal-membership
+  "PLR6201", # 847 errors
   # Method could be a function, class method, or static method
-  "PLR6301",
+  "PLR6301", # 11411 errors
   # Too many positional arguments (6/5)
-  "PLR0917",
-  # `import` should be at the top-level of a file
-  "PLC0415",
-  # Too many public methods (23 > 20)
-  "PLR0904",
-  # Too many local variables
-  "PLR0914",
-  # Too many nested blocks (6 > 5)
-  "PLR1702",
-  # Too many Boolean expressions
-  "PLR0916",
+  "PLR0917", # 470 errors
   # Private name import
-  "PLC2701",
-  # Redefining argument with the local name
-  "PLR1704",
-  # Unnecessary dunder call
-  "PLC2801",
-  # Lambda may be unnecessary; consider inlining inner function
-  # Autofix might not be correct
-  "PLW0108",
+  "PLC2701", # 27 errors
   # Object does not implement `__hash__` method
-  "PLW1641",
+  "PLW1641", # 16 errors
   # `tempfile.NamedTemporaryFile` in text mode without explicit `encoding` argument
-  "PLW1514",
+  "PLW1514", # 1 error
   # Bad or misspelled dunder method name
-  "PLW3201",
+  "PLW3201", # 69 errors, seems to be all false positive
   # Unnecessary lookup of dictionary value by key
-  "PLR1733",
+  "PLR1733", # 5 errors, it seems like we wannt to ignore these
   # Unnecessary lookup of list item by index
-  "PLR1736",
+  "PLR1736", # 4 errors, we're currently having inline pylint ignore
 
   # Output of pylint-to-ruff
   # "PLC0103",  # invalid-name
@@ -375,7 +354,7 @@ ignore = [
   # "PLC0411",  # wrong-import-order
   # "PLC0412",  # ungrouped-imports
   # "PLC0413",  # wrong-import-position
-  # "PLC0415",  # import-outside-toplevel
+  "PLC0415",  # import-outside-toplevel
   # "PLC1802",  # use-implicit-booleaness-not-len
   # "PLC1803",  # use-implicit-booleaness-not-comparison
   # "PLC1804",  # use-implicit-booleaness-not-comparison-to-string
@@ -431,7 +410,7 @@ ignore = [
   # "PLW0102",  # dangerous-default-value
   # "PLW0104",  # pointless-statement
   # "PLW0106",  # expression-not-assigned
-  "PLW0108",  # unnecessary-lambda
+  "PLW0108",  # unnecessary-lambda # # Autofix might not be correct
   # "PLW0123",  # eval-used
   # "PLW0125",  # using-constant-test
   # "PLW0143",  # comparison-with-callable