Skip to content

Commit d8b4d0b

Browse files
author
tp
committed
rename BlockManager.as_matrix to .as_array
1 parent 0d47e46 commit d8b4d0b

File tree

5 files changed

+63
-51
lines changed

5 files changed

+63
-51
lines changed

pandas/core/generic.py

+5-6
Original file line numberDiff line numberDiff line change
@@ -3773,12 +3773,11 @@ def as_matrix(self, columns=None):
37733773
--------
37743774
pandas.DataFrame.values
37753775
"""
3776-
warnings.warn("method ``as_matrix`` will be removed in a future version. "
3777-
"Use ``values`` instead.", FutureWarning, stacklevel=2)
3776+
warnings.warn("Method .as_matrix will be removed in a future version. "
3777+
"Use .values instead.", FutureWarning, stacklevel=2)
37783778
self._consolidate_inplace()
3779-
if self._AXIS_REVERSED:
3780-
return self._data.as_matrix(columns).T
3781-
return self._data.as_matrix(columns)
3779+
return self._data.as_array(transpose=self._AXIS_REVERSED,
3780+
items=columns)
37823781

37833782
@property
37843783
def values(self):
@@ -3797,7 +3796,7 @@ def values(self):
37973796
will result in a flot64 dtype.
37983797
"""
37993798
self._consolidate_inplace()
3800-
return self._data.as_matrix(transpose=self._AXIS_REVERSED)
3799+
return self._data.as_array(transpose=self._AXIS_REVERSED)
38013800

38023801
@property
38033802
def _values(self):

pandas/core/internals.py

+15-2
Original file line numberDiff line numberDiff line change
@@ -3484,7 +3484,7 @@ def replace_list(self, src_list, dest_list, inplace=False, regex=False,
34843484
mgr = self
34853485

34863486
# figure out our mask a-priori to avoid repeated replacements
3487-
values = self.as_matrix()
3487+
values = self.as_array()
34883488

34893489
def comp(s):
34903490
if isna(s):
@@ -3670,7 +3670,20 @@ def copy(self, deep=True, mgr=None):
36703670
return self.apply('copy', axes=new_axes, deep=deep,
36713671
do_integrity_check=False)
36723672

3673-
def as_matrix(self, transpose=False, items=None):
3673+
def as_array(self, transpose=False, items=None):
3674+
"""Convert the blockmanager data into an numpy array.
3675+
3676+
Parameters
3677+
----------
3678+
transpose : boolean, default False
3679+
If True, transpose the return array
3680+
items : list of strings or None
3681+
list of block items that should be included in the returned array
3682+
3683+
Returns
3684+
-------
3685+
arr : ndarray
3686+
"""
36743687
if len(self.blocks) == 0:
36753688
arr = np.empty(self.shape, dtype=float)
36763689
return arr.transpose() if transpose else arr

pandas/core/panel.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ def to_excel(self, path, na_rep='', engine=None, **kwargs):
464464

465465
def as_matrix(self):
466466
self._consolidate_inplace()
467-
return self._data.as_matrix()
467+
return self._data.as_array()
468468

469469
# ----------------------------------------------------------------------
470470
# Getting and setting elements

pandas/tests/frame/test_api.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ def test_values(self):
372372
def test_as_matrix_deprecated(self):
373373
# GH18458
374374
with tm.assert_produces_warning(FutureWarning):
375-
result = self.frame.as_matrix()
375+
result = self.frame.as_matrix(columns=self.frame.columns.tolist())
376376
expected = self.frame.values
377377
tm.assert_numpy_array_equal(result, expected)
378378

pandas/tests/internals/test_internals.py

+41-41
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ def test_copy(self, mgr):
476476
def test_sparse(self):
477477
mgr = create_mgr('a: sparse-1; b: sparse-2')
478478
# what to test here?
479-
assert mgr.as_matrix().dtype == np.float64
479+
assert mgr.as_array().dtype == np.float64
480480

481481
def test_sparse_mixed(self):
482482
mgr = create_mgr('a: sparse-1; b: sparse-2; c: f8')
@@ -485,32 +485,32 @@ def test_sparse_mixed(self):
485485

486486
# what to test here?
487487

488-
def test_as_matrix_float(self):
488+
def test_as_array_float(self):
489489
mgr = create_mgr('c: f4; d: f2; e: f8')
490-
assert mgr.as_matrix().dtype == np.float64
490+
assert mgr.as_array().dtype == np.float64
491491

492492
mgr = create_mgr('c: f4; d: f2')
493-
assert mgr.as_matrix().dtype == np.float32
493+
assert mgr.as_array().dtype == np.float32
494494

495-
def test_as_matrix_int_bool(self):
495+
def test_as_array_int_bool(self):
496496
mgr = create_mgr('a: bool-1; b: bool-2')
497-
assert mgr.as_matrix().dtype == np.bool_
497+
assert mgr.as_array().dtype == np.bool_
498498

499499
mgr = create_mgr('a: i8-1; b: i8-2; c: i4; d: i2; e: u1')
500-
assert mgr.as_matrix().dtype == np.int64
500+
assert mgr.as_array().dtype == np.int64
501501

502502
mgr = create_mgr('c: i4; d: i2; e: u1')
503-
assert mgr.as_matrix().dtype == np.int32
503+
assert mgr.as_array().dtype == np.int32
504504

505-
def test_as_matrix_datetime(self):
505+
def test_as_array_datetime(self):
506506
mgr = create_mgr('h: datetime-1; g: datetime-2')
507-
assert mgr.as_matrix().dtype == 'M8[ns]'
507+
assert mgr.as_array().dtype == 'M8[ns]'
508508

509-
def test_as_matrix_datetime_tz(self):
509+
def test_as_array_datetime_tz(self):
510510
mgr = create_mgr('h: M8[ns, US/Eastern]; g: M8[ns, CET]')
511511
assert mgr.get('h').dtype == 'datetime64[ns, US/Eastern]'
512512
assert mgr.get('g').dtype == 'datetime64[ns, CET]'
513-
assert mgr.as_matrix().dtype == 'object'
513+
assert mgr.as_array().dtype == 'object'
514514

515515
def test_astype(self):
516516
# coerce all
@@ -607,49 +607,49 @@ def test_interleave(self):
607607
for dtype in ['f8', 'i8', 'object', 'bool', 'complex', 'M8[ns]',
608608
'm8[ns]']:
609609
mgr = create_mgr('a: {0}'.format(dtype))
610-
assert mgr.as_matrix().dtype == dtype
610+
assert mgr.as_array().dtype == dtype
611611
mgr = create_mgr('a: {0}; b: {0}'.format(dtype))
612-
assert mgr.as_matrix().dtype == dtype
612+
assert mgr.as_array().dtype == dtype
613613

614614
# will be converted according the actual dtype of the underlying
615615
mgr = create_mgr('a: category')
616-
assert mgr.as_matrix().dtype == 'i8'
616+
assert mgr.as_array().dtype == 'i8'
617617
mgr = create_mgr('a: category; b: category')
618-
assert mgr.as_matrix().dtype == 'i8'
618+
assert mgr.as_array().dtype == 'i8'
619619
mgr = create_mgr('a: category; b: category2')
620-
assert mgr.as_matrix().dtype == 'object'
620+
assert mgr.as_array().dtype == 'object'
621621
mgr = create_mgr('a: category2')
622-
assert mgr.as_matrix().dtype == 'object'
622+
assert mgr.as_array().dtype == 'object'
623623
mgr = create_mgr('a: category2; b: category2')
624-
assert mgr.as_matrix().dtype == 'object'
624+
assert mgr.as_array().dtype == 'object'
625625

626626
# combinations
627627
mgr = create_mgr('a: f8')
628-
assert mgr.as_matrix().dtype == 'f8'
628+
assert mgr.as_array().dtype == 'f8'
629629
mgr = create_mgr('a: f8; b: i8')
630-
assert mgr.as_matrix().dtype == 'f8'
630+
assert mgr.as_array().dtype == 'f8'
631631
mgr = create_mgr('a: f4; b: i8')
632-
assert mgr.as_matrix().dtype == 'f8'
632+
assert mgr.as_array().dtype == 'f8'
633633
mgr = create_mgr('a: f4; b: i8; d: object')
634-
assert mgr.as_matrix().dtype == 'object'
634+
assert mgr.as_array().dtype == 'object'
635635
mgr = create_mgr('a: bool; b: i8')
636-
assert mgr.as_matrix().dtype == 'object'
636+
assert mgr.as_array().dtype == 'object'
637637
mgr = create_mgr('a: complex')
638-
assert mgr.as_matrix().dtype == 'complex'
638+
assert mgr.as_array().dtype == 'complex'
639639
mgr = create_mgr('a: f8; b: category')
640-
assert mgr.as_matrix().dtype == 'object'
640+
assert mgr.as_array().dtype == 'object'
641641
mgr = create_mgr('a: M8[ns]; b: category')
642-
assert mgr.as_matrix().dtype == 'object'
642+
assert mgr.as_array().dtype == 'object'
643643
mgr = create_mgr('a: M8[ns]; b: bool')
644-
assert mgr.as_matrix().dtype == 'object'
644+
assert mgr.as_array().dtype == 'object'
645645
mgr = create_mgr('a: M8[ns]; b: i8')
646-
assert mgr.as_matrix().dtype == 'object'
646+
assert mgr.as_array().dtype == 'object'
647647
mgr = create_mgr('a: m8[ns]; b: bool')
648-
assert mgr.as_matrix().dtype == 'object'
648+
assert mgr.as_array().dtype == 'object'
649649
mgr = create_mgr('a: m8[ns]; b: i8')
650-
assert mgr.as_matrix().dtype == 'object'
650+
assert mgr.as_array().dtype == 'object'
651651
mgr = create_mgr('a: M8[ns]; b: m8[ns]')
652-
assert mgr.as_matrix().dtype == 'object'
652+
assert mgr.as_array().dtype == 'object'
653653

654654
def test_interleave_non_unique_cols(self):
655655
df = DataFrame([
@@ -831,7 +831,7 @@ def test_equals_block_order_different_dtypes(self):
831831

832832
def test_single_mgr_ctor(self):
833833
mgr = create_single_mgr('f8', num_rows=5)
834-
assert mgr.as_matrix().tolist() == [0., 1., 2., 3., 4.]
834+
assert mgr.as_array().tolist() == [0., 1., 2., 3., 4.]
835835

836836
def test_validate_bool_args(self):
837837
invalid_values = [1, "True", [1, 2, 3], 5.0]
@@ -878,7 +878,7 @@ class TestIndexing(object):
878878
def test_get_slice(self):
879879
def assert_slice_ok(mgr, axis, slobj):
880880
# import pudb; pudb.set_trace()
881-
mat = mgr.as_matrix()
881+
mat = mgr.as_array()
882882

883883
# we maybe using an ndarray to test slicing and
884884
# might not be the full length of the axis
@@ -889,7 +889,7 @@ def assert_slice_ok(mgr, axis, slobj):
889889
len(ax) - len(slobj), dtype=bool)])
890890
sliced = mgr.get_slice(slobj, axis=axis)
891891
mat_slobj = (slice(None), ) * axis + (slobj, )
892-
tm.assert_numpy_array_equal(mat[mat_slobj], sliced.as_matrix(),
892+
tm.assert_numpy_array_equal(mat[mat_slobj], sliced.as_array(),
893893
check_dtype=False)
894894
tm.assert_index_equal(mgr.axes[axis][slobj], sliced.axes[axis])
895895

@@ -930,10 +930,10 @@ def assert_slice_ok(mgr, axis, slobj):
930930

931931
def test_take(self):
932932
def assert_take_ok(mgr, axis, indexer):
933-
mat = mgr.as_matrix()
933+
mat = mgr.as_array()
934934
taken = mgr.take(indexer, axis)
935935
tm.assert_numpy_array_equal(np.take(mat, indexer, axis),
936-
taken.as_matrix(), check_dtype=False)
936+
taken.as_array(), check_dtype=False)
937937
tm.assert_index_equal(mgr.axes[axis].take(indexer),
938938
taken.axes[axis])
939939

@@ -950,14 +950,14 @@ def assert_take_ok(mgr, axis, indexer):
950950

951951
def test_reindex_axis(self):
952952
def assert_reindex_axis_is_ok(mgr, axis, new_labels, fill_value):
953-
mat = mgr.as_matrix()
953+
mat = mgr.as_array()
954954
indexer = mgr.axes[axis].get_indexer_for(new_labels)
955955

956956
reindexed = mgr.reindex_axis(new_labels, axis,
957957
fill_value=fill_value)
958958
tm.assert_numpy_array_equal(algos.take_nd(mat, indexer, axis,
959959
fill_value=fill_value),
960-
reindexed.as_matrix(),
960+
reindexed.as_array(),
961961
check_dtype=False)
962962
tm.assert_index_equal(reindexed.axes[axis], new_labels)
963963

@@ -996,13 +996,13 @@ def test_reindex_indexer(self):
996996

997997
def assert_reindex_indexer_is_ok(mgr, axis, new_labels, indexer,
998998
fill_value):
999-
mat = mgr.as_matrix()
999+
mat = mgr.as_array()
10001000
reindexed_mat = algos.take_nd(mat, indexer, axis,
10011001
fill_value=fill_value)
10021002
reindexed = mgr.reindex_indexer(new_labels, indexer, axis,
10031003
fill_value=fill_value)
10041004
tm.assert_numpy_array_equal(reindexed_mat,
1005-
reindexed.as_matrix(),
1005+
reindexed.as_array(),
10061006
check_dtype=False)
10071007
tm.assert_index_equal(reindexed.axes[axis], new_labels)
10081008

0 commit comments

Comments
 (0)