From 6697f2d176789fae504a30edc3d3e5a34a52df88 Mon Sep 17 00:00:00 2001 From: Nick Crews Date: Tue, 8 Mar 2022 22:08:30 +0000 Subject: [PATCH 1/3] BLD: Upload sdist artifact from CI Now it is possible to inspect the sdist that is built, to see what was included and for debugging. Inspired by needing to see what was acutally included in the sdist at https://github.com/pandas-dev/pandas/pull/46271 --- .github/workflows/sdist.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/sdist.yml b/.github/workflows/sdist.yml index 1d9c8701d42d4..17b95b3aa5966 100644 --- a/.github/workflows/sdist.yml +++ b/.github/workflows/sdist.yml @@ -54,6 +54,12 @@ jobs: pip list python setup.py sdist --formats=gztar + - name: Upload sdist artifact + uses: actions/upload-artifact@v3 + with: + name: ${{ github.ref }}-${{matrix.python-version}}-sdist.gz + path: dist/*.gz + - uses: conda-incubator/setup-miniconda@v2 with: activate-environment: pandas-sdist From c153102bbf70098c824af667f6c232dbcbb39548 Mon Sep 17 00:00:00 2001 From: Nick Crews Date: Tue, 8 Mar 2022 22:28:04 +0000 Subject: [PATCH 2/3] BLD: fix artifact name Got this error before: Error: Artifact name is not valid: refs/pull/46277/merge-3.8-sdist.gz. Contains the following character: Forward slash / This is more precise anyways. --- .github/workflows/sdist.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sdist.yml b/.github/workflows/sdist.yml index 17b95b3aa5966..ff0071c7416b6 100644 --- a/.github/workflows/sdist.yml +++ b/.github/workflows/sdist.yml @@ -57,7 +57,7 @@ jobs: - name: Upload sdist artifact uses: actions/upload-artifact@v3 with: - name: ${{ github.ref }}-${{matrix.python-version}}-sdist.gz + name: ${{ github.sha }}-${{matrix.python-version}}-sdist.gz path: dist/*.gz - uses: conda-incubator/setup-miniconda@v2 From cde8218c92c09ce9d30f7dc52864d54b09720c88 Mon Sep 17 00:00:00 2001 From: Nick Crews Date: Thu, 10 Mar 2022 02:30:36 +0000 Subject: [PATCH 3/3] BLD: Drop SHA from sdist artifact name Per https://github.com/pandas-dev/pandas/pull/46277#discussion_r822232617 --- .github/workflows/sdist.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sdist.yml b/.github/workflows/sdist.yml index ff0071c7416b6..431710a49a7dd 100644 --- a/.github/workflows/sdist.yml +++ b/.github/workflows/sdist.yml @@ -57,7 +57,7 @@ jobs: - name: Upload sdist artifact uses: actions/upload-artifact@v3 with: - name: ${{ github.sha }}-${{matrix.python-version}}-sdist.gz + name: ${{matrix.python-version}}-sdist.gz path: dist/*.gz - uses: conda-incubator/setup-miniconda@v2