Transaction, TransactionSigned

[taranvd]

Hi everyone. It was working on version 1.0.8, but today I updated to 1.2.0. Could you please tell me how to correctly use "Transaction, TransactionSigned" now? Thanks for your help

[mattsse]

the way this is layered now is

reth/crates/ethereum/primitives/src/transaction.rs

Lines 298 to 309 in 34b7145

	pub struct TransactionSigned {
	/// Transaction hash
	#[serde(skip)]
	hash: OnceLock<TxHash>,
	/// The transaction signature values
	signature: Signature,
	/// Raw transaction info
	#[deref]
	#[as_ref]
	#[cfg_attr(feature = "test-utils", deref_mut)]
	transaction: Transaction,
	}

and the transactionSginedEcRecovered type is now deprecated in favor of Recovered, e.g:

reth/crates/primitives-traits/src/transaction/signed.rs

Line 114 in 34b7145

fn try_into_recovered(self) -> Result<Recovered<Self>, Self> {

depending on what you work on, you might want to operate on trait SignedTransaction instead:

reth/crates/primitives-traits/src/transaction/signed.rs

Line 22 in 34b7145

pub trait SignedTransaction:

[taranvd]

root cargo.toml

reth-ethereum-primitives = { package = "reth-ethereum-primitives", git = "https://github.com/paradigmxyz/reth", tag = "v1.2.0"}

crate:

reth-ethereum-primitives.workspace = true

use reth_ethereum_primitives::TransactionSigned;

Unresolved import: reth_ethereum_primitives::TransactionSigned

[mattsse]

is this a compiler error?
because that type should definitely be there

[taranvd]

I can't access these types. Here's the file reth_ethereum_primitives:

#![doc(
    html_logo_url = "https://raw.githubusercontent.com/paradigmxyz/reth/main/assets/reth-docs.png",
    html_favicon_url = "https://avatars0.githubusercontent.com/u/97369466?s=256",
    issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/"
)]
#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
#![cfg_attr(not(feature = "std"), no_std)]

extern crate alloc;

mod receipt;
pub use receipt::*;

mod transaction;
pub use transaction::*;

#[cfg(feature = "alloy-compat")]
mod alloy_compat;

/// Type alias for the ethereum block
pub type Block = alloy_consensus::Block<TransactionSigned>;

/// Type alias for the ethereum blockbody
pub type BlockBody = alloy_consensus::BlockBody<TransactionSigned>;

/// Helper struct that specifies the ethereum
/// [`NodePrimitives`](reth_primitives_traits::NodePrimitives) types.
#[derive(Debug, Clone, Default, PartialEq, Eq, serde::Serialize, serde::Deserialize)]
#[non_exhaustive]
pub struct EthPrimitives;

impl reth_primitives_traits::NodePrimitives for EthPrimitives {
    type Block = crate::Block;
    type BlockHeader = alloy_consensus::Header;
    type BlockBody = crate::BlockBody;
    type SignedTx = crate::TransactionSigned;
    type Receipt = crate::Receipt;
}

Can you try this on your setup and let me know if it works for you?

[mattsse]

hmm, it's right there on v1.2.0

reth/crates/ethereum/primitives/src/transaction.rs

Lines 292 to 297 in 1e965ca

	/// Signed Ethereum transaction.
	#[derive(Debug, Clone, Eq, Serialize, Deserialize, derive_more::AsRef, derive_more::Deref)]
	#[cfg_attr(any(test, feature = "reth-codec"), reth_codecs::add_arbitrary_tests(rlp))]
	#[cfg_attr(feature = "test-utils", derive(derive_more::DerefMut))]
	#[serde(rename_all = "camelCase")]
	pub struct TransactionSigned {