Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Maybeconditional with helper fn #14509

Closed
mattsse opened this issue Feb 15, 2025 · 1 comment · Fixed by #14511
Closed

Extend Maybeconditional with helper fn #14509

mattsse opened this issue Feb 15, 2025 · 1 comment · Fixed by #14511
Assignees
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 15, 2025

Describe the feature

in #14497 we added:

if let Some(conditional) = tx.transaction.conditional() {
if conditional.has_exceeded_block_attributes(&block_attr) {
to_remove.push(*tx.hash());
}
}

we can simplify this by adding has_exceeded_block_attributes directly to the trait:

pub trait MaybeConditionalTransaction {

so we don't need the extra option handling

TODO

  • add default impl for has_exceeded_block_attributes

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 15, 2025
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-op-reth Related to Optimism and op-reth and removed S-needs-triage This issue needs to be labelled labels Feb 15, 2025
@programskillforverification
Copy link
Contributor

Hey, I'd like to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants