Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dompurify dependency #3819

Closed
StefanJonssonInExchange opened this issue Feb 3, 2025 · 5 comments · Fixed by #3827
Closed

Dompurify dependency #3819

StefanJonssonInExchange opened this issue Feb 3, 2025 · 5 comments · Fixed by #3827

Comments

@StefanJonssonInExchange
Copy link

Hi, I see here that you recently updated dompurify dependency due to an aikido issue. That's great.

However, if you scan again there will be a new issue that can be found here, and it seems like you need to update again to 3.2.4 or above.

I tried to do a PR for this but I seem to be lacking permission to push my local branch.

So I have two questions.

  • Can you update the package again?
  • How can I know when it will be released? On NPM the last publish was 5months ago, but latest commit in master is 2weeks ago.

Thanks in advance.

@hainenber
Copy link
Contributor

The next package is one major version away from the recently updated one so I guess the author will have to consider whether IE11 is still supported for their case currently. DOMPurify v3 no longer supports Microsoft Internet Explorer, according to its release.

cc @HackbrettXXX as you are the original author for this change with the original context.

@rescarabel0
Copy link

rescarabel0 commented Feb 17, 2025

looks like there's even a vulnerability in GitHub Database (GHSA-vhxf-7vqr-mrjg) and this is actually becoming a problem, the npm audit on my automation isn't letting this pass

@HackbrettXXX
Copy link
Collaborator

I think dropping IE support is ok. We would have to release a new major version of jsPDF, but that's fine. We would have dropped IE support anyway some time in the future. Could someone prepare a PR? I will merge it and release the new version.

@hainenber
Copy link
Contributor

Thanks for the revert! I'll set up a PR

@hainenber
Copy link
Contributor

hainenber commented Feb 18, 2025

New PR just dropped with flying green colors from CI :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants