Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup more benevolent peerDependencies for SDK #410

Closed
vikiival opened this issue Sep 20, 2024 · 1 comment · Fixed by #414
Closed

Setup more benevolent peerDependencies for SDK #410

vikiival opened this issue Sep 20, 2024 · 1 comment · Fixed by #414
Assignees
Labels
enhancement New feature or request maintenance work XCM SDK Issue is about XCM SDK

Comments

@vikiival
Copy link
Collaborator

vikiival commented Sep 20, 2024

Context

Observing package.json in XCM SDK I have found out that the rules for peerDependencies are pretty strict

Solution

I would prefer to have more benevolent rules for packages

e.g:
current

  "peerDependencies": {
    "@polkadot/api": "^12.4.2",
    "@polkadot/api-base": "^12.4.2",
    "@polkadot/apps-config": "^0.143.2",
    "@polkadot/types": "^12.4.2",
    "@polkadot/util": "^13.0.2"
  }

ideal

  "peerDependencies": {
    "@polkadot/api": ">= 12.4",
    "@polkadot/api-base": ">= 12.4",
    "@polkadot/apps-config": ">= 0.143",
    "@polkadot/types": ">= 12.4",
    "@polkadot/util": ">= 13"
  }

Ref

@dudo50
Copy link
Contributor

dudo50 commented Sep 21, 2024

@vikiival , added :). Thanks for the improvement suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance work XCM SDK Issue is about XCM SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants