Migrate 0009-approval-voting-coalescing.zndsl to zombienet-sdk #7666
Conversation
Signed-off-by: Alexandru Gheorghe <[email protected]>
polkadot/zombienet-sdk-tests/tests/functional/approval_voting_coalescing.rs
Outdated
Show resolved
Hide resolved
polkadot/zombienet-sdk-tests/tests/functional/approval_voting_coalescing.rs
Show resolved
Hide resolved
| .with_parachain(|p| { | ||
| p.with_id(2000) | ||
| .with_default_command("undying-collator") | ||
| .with_default_image( | ||
| std::env::var("COL_IMAGE") | ||
| .unwrap_or("docker.io/paritypr/colander:latest".to_string()) | ||
| .as_str(), | ||
| ) | ||
| .cumulus_based(false) | ||
| .with_default_args(vec![("-lparachain=debug").into()]) | ||
| .with_collator(|n| n.with_name("collator-undying-2000")) | ||
| }) | ||
| .with_parachain(|p| { | ||
| p.with_id(2001) | ||
| .with_default_command("undying-collator") | ||
| .with_default_image( | ||
| std::env::var("COL_IMAGE") | ||
| .unwrap_or("docker.io/paritypr/colander:latest".to_string()) | ||
| .as_str(), | ||
| ) | ||
| .cumulus_based(false) | ||
| .with_default_args(vec![("-lparachain=debug").into()]) | ||
| .with_collator(|n| n.with_name("collator-undying-2001")) | ||
| }) | ||
| .with_parachain(|p| { | ||
| p.with_id(2002) | ||
| .with_default_command("undying-collator") | ||
| .with_default_image( |
There was a problem hiding this comment.
Can't we dedup ? Feels weird to just copy paste all of these para config.
There was a problem hiding this comment.
I kind of copy-pasted from other tests @pepoviola is there a more elegant way to express all this identical parachains where just the id differs ?
There was a problem hiding this comment.
:D never mind, I was lazy it is easy to avoid duplication :D
…coalescing.rs Co-authored-by: Andrei Sandu <[email protected]>
| @@ -449,6 +441,22 @@ zombienet-polkadot-functional-async-backing-6-seconds-rate: | |||
| - unset NEXTEST_SUCCESS_OUTPUT | |||
| - cargo nextest run --archive-file ./artifacts/polkadot-zombienet-tests.tar.zst --no-capture -- functional::async_backing_6_seconds_rate::async_backing_6_seconds_rate_test | |||
|
|
|||
| zombienet-polkadot-functional-approval-voting-coalescing:: | |||
There was a problem hiding this comment.
I think we can move this test to gha as part of this migration, since we need to move to gha at some point to shutdown gitlab. I can push those changes here @alexggh if you are agree?
Thx!
There was a problem hiding this comment.
Yes, definitely, we don't want to migrate twice, so feel free to push here whatever needs pushing.
Signed-off-by: Alexandru Gheorghe <[email protected]>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Fixes: #7651