Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2503] Backport #7670 #7675

Open
wants to merge 3 commits into
base: stable2503
Choose a base branch
from

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link
Contributor

Backport #7670 into stable2503 from davxy.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7670-to-stable2503
git worktree add --checkout .worktree/backport-7670-to-stable2503 backport-7670-to-stable2503
cd .worktree/backport-7670-to-stable2503
git reset --hard HEAD^
git cherry-pick -x 21f6f0705e53c15aa2b8a5706b208200447774a9
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Feb 23, 2025
[[package]]
name = "sp-runtime-interface"
version = "24.0.0"
source = "git+https://github.com/paritytech/polkadot-sdk#934c091421af4be362839996bfaa441ba59bf12b"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are pulling in a lot of sp- dependencies multiple times, since the bandersnatch stuff is not on crates-io...

ggwpez
ggwpez previously approved these changes Feb 24, 2025
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez force-pushed the backport-7670-to-stable2503 branch from 08e0d74 to b299905 Compare February 24, 2025 11:13
ggwpez
ggwpez previously approved these changes Feb 24, 2025
@ggwpez ggwpez marked this pull request as ready for review February 24, 2025 11:14
@ggwpez ggwpez requested a review from a team as a code owner February 24, 2025 11:14
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev
Copy link
Contributor

EgorPopelyaev commented Feb 24, 2025

@ggwpez do we need to bump pallet-sassafras and sp-core here? aka prdoc stuff😄

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Member

ggwpez commented Feb 24, 2025

Yea true - dont know why the original was marked as silent 🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants