Backports to v0.6 (#493)

* Fix compilation in wasm (#465)

Also fix the weird file structure by making `wasm_executor.rs` ->
`wasm_executor/mod.rs`.

* Changes for substrate#3699 (#466)

* change upstream and branch

* Fix build

* remove doc renamings

* Fix tests

* .

* Revert changing fork and branch

* Update Cargo.toml

* Update parachains.rs

* wasm_executor: fix wasm signature checker (#471)

Signed-off-by: yjhmelody <[email protected]>

* Update to latest Substrate master (#472)

* Update to latest Substrate master

* Fix

* Fix compilation

* fix var name for post_upward_message (#474)

Signed-off-by: yjhmelody <[email protected]>

* integrate minor weight/fee changes (#482)

* Update cargo files

* Make it build again.

* Fix build

* revert cargo file

* New lockfile

* Bump.

* Update to latest Substrate master (#486)

* Only register one gossip validator for full nodes (#487)

* Support `account_nextIndex` RPC. (#460)

* Use node-rpc extensions to support account_nextIndex.

* Remove todo.

* Update lock.

* Use new srml_system_rpc crate.

* Update to substrate=master

* Update lockfile.

* Update to polkadot-master.

* Apply suggestions from code review

Co-Authored-By: Bastian Köcher <[email protected]>

* Update to latest substrate master (#491)

* update to latest substrate master

* Fix compilation

Author: andresilva

Cargo.lock

@@ -10,6 +10,6 @@ log = "0.4.6"
 tokio = "0.1.7"
 futures = "0.1.17"
 exit-future = "0.1"
-structopt = "0.2"
+structopt = "0.3.3"
 cli = { package = "substrate-cli", git = "https://github.com/paritytech/substrate", branch = "polkadot-master" }
 service = { package = "polkadot-service", path = "../service" }

cli/Cargo.toml

@@ -72,7 +72,7 @@ pub trait Worker: IntoExit {
 
 #[derive(Debug, StructOpt, Clone)]
 enum PolkadotSubCommands {
-	#[structopt(name = "validation-worker", raw(setting = "structopt::clap::AppSettings::Hidden"))]
+	#[structopt(name = "validation-worker", setting = structopt::clap::AppSettings::Hidden)]
 	ValidationWorker(ValidationWorkerCommand),
 }
 

cli/src/lib.rs

@@ -16,6 +16,7 @@ substrate-network = { git = "https://github.com/paritytech/substrate", branch =
 substrate-primitives = { git = "https://github.com/paritytech/substrate", branch = "polkadot-master" }
 sr-primitives = { git = "https://github.com/paritytech/substrate", branch = "polkadot-master" }
 futures = "0.1"
+futures03 = { package = "futures-preview", version = "0.3.0-alpha.19", features = ["compat"] }
 log = "0.4"
 exit-future = "0.1.4"
 substrate-client = { git = "https://github.com/paritytech/substrate", branch = "polkadot-master" }

network/Cargo.toml

@@ -342,16 +342,6 @@ impl NewLeafActions {
 	}
 }
 
-/// Register a gossip validator for a non-authority node.
-pub fn register_non_authority_validator(service: Arc<PolkadotNetworkService>) {
-	service.with_gossip(|gossip, ctx|
-		gossip.register_validator(
-			ctx,
-			POLKADOT_ENGINE_ID,
-			Arc::new(substrate_network::consensus_gossip::DiscardAll)),
-	);
-}
-
 /// A registered message validator.
 ///
 /// Create this using `register_validator`.

network/src/gossip.rs

@@ -26,8 +26,9 @@ pub mod validation;
 pub mod gossip;
 
 use codec::{Decode, Encode};
-use futures::sync::{oneshot, mpsc};
+use futures::sync::oneshot;
 use futures::prelude::*;
+use futures03::{channel::mpsc, compat::Compat, StreamExt};
 use polkadot_primitives::{Block, Hash, Header};
 use polkadot_primitives::parachain::{
 	Id as ParaId, BlockData, CollatorId, CandidateReceipt, Collation, PoVBlock,
@@ -108,7 +109,7 @@ impl NetworkService for PolkadotNetworkService {
 			Err(_) => mpsc::unbounded().1, // return empty channel.
 		};
 
-		GossipMessageStream::new(topic_stream)
+		GossipMessageStream::new(Box::new(Compat::new(topic_stream.map(Ok))))
 	}
 
 	fn gossip_message(&self, topic: Hash, message: GossipMessage) {
@@ -151,14 +152,14 @@ impl GossipService for consensus_gossip::ConsensusGossip<Block> {
 
 /// A stream of gossip messages and an optional sender for a topic.
 pub struct GossipMessageStream {
-	topic_stream: mpsc::UnboundedReceiver<TopicNotification>,
+	topic_stream: Box<dyn Stream<Item = TopicNotification, Error = ()> + Send>,
 }
 
 impl GossipMessageStream {
 	/// Create a new instance with the given topic stream.
-	pub fn new(topic_stream: mpsc::UnboundedReceiver<TopicNotification>) -> Self {
+	pub fn new(topic_stream: Box<dyn Stream<Item = TopicNotification, Error = ()> + Send>) -> Self {
 		Self {
-			topic_stream
+			topic_stream,
 		}
 	}
 }

network/src/lib.rs

@@ -148,7 +148,7 @@ impl NetworkService for TestNetwork {
 	fn gossip_messages_for(&self, topic: Hash) -> GossipMessageStream {
 		let (tx, rx) = mpsc::unbounded();
 		let _  = self.gossip.send_listener.unbounded_send((topic, tx));
-		GossipMessageStream::new(rx)
+		GossipMessageStream::new(Box::new(rx))
 	}
 
 	fn gossip_message(&self, topic: Hash, message: GossipMessage) {

network/src/tests/validation.rs

@@ -10,6 +10,7 @@ codec = { package = "parity-scale-codec", version = "1.0.5", default-features =
 wasmi = { version = "0.4.3", optional = true }
 derive_more = { version = "0.14", optional = true }
 serde = { version = "1.0", default-features = false, features = [ "derive" ] }
+substrate-primitives = { package = "substrate-primitives", git = "https://github.com/paritytech/substrate", default-features = false, branch = "polkadot-master" }
 rstd = { package = "sr-std", git = "https://github.com/paritytech/substrate", branch = "polkadot-master", default-features = false }
 lazy_static = { version = "1.3.0", optional = true }
 parking_lot = { version = "0.7.1", optional = true }
@@ -31,6 +32,7 @@ std = [
 	"wasmi",
 	"derive_more",
 	"serde/std",
+	"substrate-primitives/std",
 	"rstd/std",
 	"shared_memory",
 	"lazy_static",

parachain/Cargo.toml

@@ -54,6 +54,7 @@ pub mod wasm_api;
 use rstd::vec::Vec;
 
 use codec::{Encode, Decode, CompactAs};
+use substrate_primitives::RuntimeDebug;
 
 /// Validation parameters for evaluating the parachain validity function.
 // TODO: balance downloads (https://github.com/paritytech/polkadot/issues/220)
@@ -78,8 +79,11 @@ pub struct ValidationResult {
 }
 
 /// Unique identifier of a parachain.
-#[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Default, Clone, Copy, CompactAs, Encode, Decode)]
-#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize, Debug))]
+#[derive(
+	Clone, CompactAs, Copy, Decode, Default, Encode, Eq,
+	Hash, Ord, PartialEq, PartialOrd, RuntimeDebug
+)]
+#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
 pub struct Id(u32);
 
 impl From<Id> for u32 {

parachain/src/lib.rs

@@ -32,8 +32,7 @@ use super::{
 	UpwardMessage, IncomingMessage};
 
 #[cfg(not(target_os = "unknown"))]
-pub use validation_host::run_worker;
-pub use validation_host::EXECUTION_TIMEOUT_SEC;
+pub use validation_host::{run_worker, EXECUTION_TIMEOUT_SEC};
 
 mod validation_host;
 
@@ -46,7 +45,7 @@ mod ids {
 	pub const POST_MESSAGE: usize = 1;
 
 	/// Post a message to this parachain's relay chain.
-	pub const POST_UPWARDS_MESSAGE: usize = 2;
+	pub const POST_UPWARD_MESSAGE: usize = 2;
 }
 
 /// WASM code execution mode.
@@ -125,7 +124,7 @@ impl fmt::Display for ExternalitiesError {
 }
 
 impl wasmi::HostError for ExternalitiesError {}
-impl ::std::error::Error for ExternalitiesError {}
+impl std::error::Error for ExternalitiesError {}
 
 struct Resolver {
 	max_memory: u32, // in pages.
@@ -144,7 +143,7 @@ impl ModuleImportResolver for Resolver {
 				let (params, ret_ty): (&[ValueType], Option<ValueType>) =
 					(&[ValueType::I32, ValueType::I32, ValueType::I32], None);
 
-				if signature.params() != params && signature.return_type() != ret_ty {
+				if signature.params() != params || signature.return_type() != ret_ty {
 					Err(WasmError::Instantiation(
 						format!("Export {} has a bad signature", field_name)
 					))
@@ -156,11 +155,11 @@ impl ModuleImportResolver for Resolver {
 				}
 			}
 			"ext_upwards_post_message" => {
-				let index = ids::POST_UPWARDS_MESSAGE;
+				let index = ids::POST_UPWARD_MESSAGE;
 				let (params, ret_ty): (&[ValueType], Option<ValueType>) =
 					(&[ValueType::I32, ValueType::I32], None);
 
-				if signature.params() != params && signature.return_type() != ret_ty {
+				if signature.params() != params || signature.return_type() != ret_ty {
 					Err(WasmError::Instantiation(
 						format!("Export {} has a bad signature", field_name)
 					))
@@ -269,7 +268,7 @@ impl<'a, E: 'a + Externalities> Externals for ValidationExternals<'a, E> {
 	) -> Result<Option<RuntimeValue>, Trap> {
 		match index {
 			ids::POST_MESSAGE => self.ext_post_message(args).map(|_| None),
-			ids::POST_UPWARDS_MESSAGE => self.ext_post_upward_message(args).map(|_| None),
+			ids::POST_UPWARD_MESSAGE => self.ext_post_upward_message(args).map(|_| None),
 			_ => panic!("no externality at given index"),
 		}
 	}