cargo: Switch to workspace lints

Signed-off-by: Alexandru Vasile <[email protected]>

Author: lexnv

Cargo.toml

@@ -36,6 +36,29 @@ repository = "https://github.com/paritytech/subxt"
 documentation = "https://docs.rs/subxt"
 homepage = "https://www.parity.io/"
 
+[workspace.lints.rust]
+bad_style = "deny"
+improper_ctypes = "deny"
+missing_docs = "deny"
+non_shorthand_field_patterns = "deny"
+no_mangle_generic_items = "deny"
+overflowing_literals = "deny"
+path_statements = "deny"
+patterns_in_fns_without_body = "deny"
+unconditional_recursion = "deny"
+unused_allocation = "deny"
+unused_comparisons = "deny"
+unused_parens = "deny"
+while_true = "deny"
+trivial_casts = "deny"
+trivial_numeric_casts = "deny"
+unused_crate_dependencies = "deny"
+unused_extern_crates = "deny"
+
+[workspace.lints.clippy]
+type_complexity = "allow"
+all = "deny"
+
 [workspace.dependencies]
 async-trait = "0.1.74"
 assert_matches = "1.5.0"

cli/Cargo.toml

@@ -16,6 +16,9 @@ description = "Command line utilities for working with subxt codegen"
 name = "subxt"
 path = "src/main.rs"
 
+[lints]
+workspace = true
+
 [features]
 # Compute the state root hash from the genesis entry.
 # Enable this to create a smaller chain spec file.

cli/build.rs

@@ -1,3 +1,5 @@
+//! Build script for the CLI.
+
 use std::{borrow::Cow, process::Command};
 
 fn main() {

cli/src/main.rs

@@ -2,7 +2,7 @@
 // This file is dual-licensed as Apache-2.0 or GPL-3.0.
 // see LICENSE for license details.
 
-#![deny(unused_crate_dependencies)]
+//! The Subxt CLI tool.
 
 mod commands;
 mod utils;

codegen/Cargo.toml

@@ -12,6 +12,9 @@ documentation = "https://docs.rs/subxt-codegen"
 homepage.workspace = true
 description = "Generate an API for interacting with a substrate node from FRAME metadata"
 
+[lints]
+workspace = true
+
 [features]
 default = []
 fetch-metadata = ["dep:jsonrpsee", "dep:tokio", "dep:frame-metadata"]

codegen/src/lib.rs

@@ -6,8 +6,6 @@
 //! This is used by the `#[subxt]` macro and `subxt codegen` CLI command, but can also
 //! be used directly if preferable.
 
-#![deny(unused_crate_dependencies, missing_docs)]
-
 mod api;
 mod ir;
 mod types;

lightclient/Cargo.toml

@@ -14,6 +14,9 @@ homepage.workspace = true
 description = "Light Client for chain interaction"
 keywords = ["parity", "substrate", "blockchain"]
 
+[lints]
+workspace = true
+
 [features]
 default = ["native"]
 

lightclient/src/lib.rs

@@ -10,14 +10,6 @@
 //!
 //! This leverages the smoldot crate to connect to the chain.
 
-#![deny(
-    missing_docs,
-    unused_crate_dependencies,
-    unused_extern_crates,
-    clippy::all
-)]
-#![allow(clippy::type_complexity)]
-
 #[cfg(any(
     all(feature = "web", feature = "native"),
     not(any(feature = "web", feature = "native"))

macro/Cargo.toml

@@ -13,6 +13,9 @@ documentation.workspace = true
 homepage.workspace = true
 description = "Generate types and helpers for interacting with Substrate runtimes."
 
+[lints]
+workspace = true
+
 [features]
 web = ["subxt-codegen/web"]
 

macro/src/lib.rs

@@ -2,7 +2,7 @@
 // This file is dual-licensed as Apache-2.0 or GPL-3.0.
 // see LICENSE for license details.
 
-extern crate proc_macro;
+//! Subxt macro for generating Substrate runtime interfaces.
 
 use codec::Decode;
 use darling::{ast::NestedMeta, FromMeta};
@@ -73,7 +73,8 @@ struct SubstituteType {
     with: syn::Path,
 }
 
-// Note: docs for this are in the subxt library; don't add any here as they will be appended.
+// Note: docs for this are in the subxt library; don't add further docs here as they will be appended.
+/// The subxt macro.
 #[proc_macro_attribute]
 #[proc_macro_error]
 pub fn subxt(args: TokenStream, input: TokenStream) -> TokenStream {

metadata/Cargo.toml

@@ -13,6 +13,9 @@ documentation.workspace = true
 homepage.workspace = true
 description = "Command line utilities for checking metadata compatibility between nodes."
 
+[lints]
+workspace = true
+
 [dependencies]
 codec = { package = "parity-scale-codec", workspace = true, features = ["derive"] }
 frame-metadata = { workspace = true }

metadata/benches/bench.rs

@@ -2,6 +2,8 @@
 // This file is dual-licensed as Apache-2.0 or GPL-3.0.
 // see LICENSE for license details.
 
+//! Benchmarks for metadata hashing.
+
 use codec::Decode;
 use criterion::*;
 use frame_metadata::{RuntimeMetadata, RuntimeMetadataPrefixed};

metadata/src/lib.rs

@@ -14,8 +14,6 @@
 //! 2. Obtaining [`frame_metadata::RuntimeMetadataPrefixed`], and then
 //!    using `.try_into()` to convert it into [`Metadata`].
 
-#![deny(missing_docs)]
-
 mod from_into;
 mod utils;
 

signer/src/lib.rs

@@ -13,8 +13,6 @@
 //! Enable the `subxt` feature to enable use of this [`sr25519::Keypair`] in signing
 //! subxt transactions for chains supporting sr25519 signatures.
 
-#![deny(missing_docs)]
-
 #[macro_use]
 mod utils;
 mod crypto;

subxt/Cargo.toml

@@ -14,6 +14,9 @@ homepage.workspace = true
 description = "Submit extrinsics (transactions) to a substrate node via RPC"
 keywords = ["parity", "substrate", "blockchain"]
 
+[lints]
+workspace = true
+
 [features]
 # For dev and documentation reasons we enable more features than are often desired.
 # it's recommended to use `--no-default-features` and then select what you need.

subxt/src/lib.rs

@@ -10,28 +10,6 @@
 //!
 //! Take a look at [the Subxt guide](book) to learn more about how to use Subxt.
 
-#![deny(
-    bad_style,
-    improper_ctypes,
-    missing_docs,
-    non_shorthand_field_patterns,
-    no_mangle_generic_items,
-    overflowing_literals,
-    path_statements,
-    patterns_in_fns_without_body,
-    unconditional_recursion,
-    unused_allocation,
-    unused_comparisons,
-    unused_parens,
-    while_true,
-    trivial_casts,
-    trivial_numeric_casts,
-    unused_crate_dependencies,
-    unused_extern_crates,
-    clippy::all
-)]
-#![allow(clippy::type_complexity)]
-
 #[cfg(any(
     all(feature = "web", feature = "native"),
     not(any(feature = "web", feature = "native"))