Skip to content

Commit 04b41a5

Browse files
author
Arthur Cinader
authored
Merge pull request #313 from montymxb/test-fixes
Updates various tests.
2 parents cd10464 + 1bd2dc2 commit 04b41a5

File tree

3 files changed

+26
-21
lines changed

3 files changed

+26
-21
lines changed

src/Parse/ParseClient.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ final class ParseClient
111111
*
112112
* @var string
113113
*/
114-
const VERSION_STRING = 'php1.2.2';
114+
const VERSION_STRING = 'php1.2.7';
115115

116116
/**
117117
* Parse\Client::initialize, must be called before using Parse features.

tests/Parse/ParseClientTest.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,8 @@ public function testBadApiResponse()
514514
$httpClient = ParseClient::getHttpClient();
515515

516516
// create a mock of the current http client
517-
$stubClient = $this->createMock(get_class($httpClient));
517+
$stubClient = $this->getMockBuilder(get_class($httpClient))
518+
->getMock();
518519

519520
// stub the response type to return
520521
// something we will try to work with

tests/Parse/ParseQueryTest.php

+23-19
Original file line numberDiff line numberDiff line change
@@ -1499,20 +1499,23 @@ public function testOrderByCreatedAtDesc()
14991499
}
15001500
}
15011501

1502+
/**
1503+
* @group order-by-updated-at
1504+
*/
15021505
public function testOrderByUpdatedAtAsc()
15031506
{
15041507
$numbers = [3, 1, 2];
15051508
$objects = [];
1506-
$this->saveObjects(
1507-
3,
1508-
function ($i) use ($numbers, &$objects) {
1509-
$obj = ParseObject::create('TestObject');
1510-
$obj->set('number', $numbers[$i]);
1511-
$objects[] = $obj;
15121509

1513-
return $obj;
1514-
}
1515-
);
1510+
foreach($numbers as $num) {
1511+
$obj = ParseObject::create('TestObject');
1512+
$obj->set('number', $num);
1513+
$obj->save();
1514+
$objects[] = $obj;
1515+
sleep(1);
1516+
1517+
}
1518+
15161519
$objects[1]->set('number', 4);
15171520
$objects[1]->save();
15181521
$query = new ParseQuery('TestObject');
@@ -1541,16 +1544,16 @@ public function testOrderByUpdatedAtDesc()
15411544
{
15421545
$numbers = [3, 1, 2];
15431546
$objects = [];
1544-
$this->saveObjects(
1545-
3,
1546-
function ($i) use ($numbers, &$objects) {
1547-
$obj = ParseObject::create('TestObject');
1548-
$obj->set('number', $numbers[$i]);
1549-
$objects[] = $obj;
15501547

1551-
return $obj;
1552-
}
1553-
);
1548+
foreach($numbers as $num) {
1549+
$obj = ParseObject::create('TestObject');
1550+
$obj->set('number', $num);
1551+
$obj->save();
1552+
$objects[] = $obj;
1553+
sleep(1);
1554+
1555+
}
1556+
15541557
$objects[1]->set('number', 4);
15551558
$objects[1]->save();
15561559
$query = new ParseQuery('TestObject');
@@ -1561,7 +1564,8 @@ function ($i) use ($numbers, &$objects) {
15611564
count($results),
15621565
'Did not return correct number of objects.'
15631566
);
1564-
$expected = [4, 3, 2];
1567+
1568+
$expected = [4, 2, 3];
15651569
for ($i = 0; $i < 3; ++$i) {
15661570
$this->assertEquals(
15671571
$expected[$i],

0 commit comments

Comments
 (0)