Skip to content

Commit 3fb6b2b

Browse files
dblythymtrezza
authored andcommitted
ci: fix flaky tests for Apple Game Center authentication (#7958)
1 parent e849cf5 commit 3fb6b2b

File tree

3 files changed

+37
-11
lines changed

3 files changed

+37
-11
lines changed

spec/AuthenticationAdapters.spec.js

+8-11
Original file line numberDiff line numberDiff line change
@@ -1652,7 +1652,8 @@ describe('apple signin auth adapter', () => {
16521652

16531653
describe('Apple Game Center Auth adapter', () => {
16541654
const gcenter = require('../lib/Adapters/Auth/gcenter');
1655-
1655+
const fs = require('fs');
1656+
const testCert = fs.readFileSync(__dirname + '/support/cert/game_center.pem');
16561657
it('validateAuthData should validate', async () => {
16571658
// real token is used
16581659
const authData = {
@@ -1664,26 +1665,22 @@ describe('Apple Game Center Auth adapter', () => {
16641665
salt: 'DzqqrQ==',
16651666
bundleId: 'cloud.xtralife.gamecenterauth',
16661667
};
1667-
1668+
gcenter.cache['https://static.gc.apple.com/public-key/gc-prod-4.cer'] = testCert;
16681669
await gcenter.validateAuthData(authData);
16691670
});
16701671

16711672
it('validateAuthData invalid signature id', async () => {
16721673
const authData = {
16731674
id: 'G:1965586982',
1674-
publicKeyUrl: 'https://static.gc.apple.com/public-key/gc-prod-4.cer',
1675+
publicKeyUrl: 'https://static.gc.apple.com/public-key/gc-prod-6.cer',
16751676
timestamp: 1565257031287,
16761677
signature: '1234',
16771678
salt: 'DzqqrQ==',
1678-
bundleId: 'cloud.xtralife.gamecenterauth',
1679+
bundleId: 'com.example.com',
16791680
};
1680-
1681-
try {
1682-
await gcenter.validateAuthData(authData);
1683-
fail();
1684-
} catch (e) {
1685-
expect(e.message).toBe('Apple Game Center - invalid signature');
1686-
}
1681+
await expectAsync(gcenter.validateAuthData(authData)).toBeRejectedWith(
1682+
new Parse.Error(Parse.Error.SCRIPT_FAILED, 'Apple Game Center - invalid signature')
1683+
);
16871684
});
16881685

16891686
it('validateAuthData invalid public key http url', async () => {

spec/support/cert/game_center.pem

+28
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
-----BEGIN CERTIFICATE-----
2+
MIIEvDCCA6SgAwIBAgIQXRHxNXkw1L9z5/3EZ/T/hDANBgkqhkiG9w0BAQsFADB/
3+
MQswCQYDVQQGEwJVUzEdMBsGA1UEChMUU3ltYW50ZWMgQ29ycG9yYXRpb24xHzAd
4+
BgNVBAsTFlN5bWFudGVjIFRydXN0IE5ldHdvcmsxMDAuBgNVBAMTJ1N5bWFudGVj
5+
IENsYXNzIDMgU0hBMjU2IENvZGUgU2lnbmluZyBDQTAeFw0xODA5MTcwMDAwMDBa
6+
Fw0xOTA5MTcyMzU5NTlaMHMxCzAJBgNVBAYTAlVTMRMwEQYDVQQIDApDYWxpZm9y
7+
bmlhMRIwEAYDVQQHDAlDdXBlcnRpbm8xFDASBgNVBAoMC0FwcGxlLCBJbmMuMQ8w
8+
DQYDVQQLDAZHQyBTUkUxFDASBgNVBAMMC0FwcGxlLCBJbmMuMIIBIjANBgkqhkiG
9+
9w0BAQEFAAOCAQ8AMIIBCgKCAQEA06fwIi8fgKrTQu7cBcFkJVF6+Tqvkg7MKJTM
10+
IOYPPQtPF3AZYPsbUoRKAD7/JXrxxOSVJ7vU1mP77tYG8TcUteZ3sAwvt2dkRbm7
11+
ZO6DcmSggv1Dg4k3goNw4GYyCY4Z2/8JSmsQ80Iv/UOOwynpBziEeZmJ4uck6zlA
12+
17cDkH48LBpKylaqthym5bFs9gj11pto7mvyb5BTcVuohwi6qosvbs/4VGbC2Nsz
13+
ie416nUZfv+xxoXH995gxR2mw5cDdeCew7pSKxEhvYjT2nVdQF0q/hnPMFnOaEyT
14+
q79n3gwFXyt0dy8eP6KBF7EW9J6b7ubu/j7h+tQfxPM+gTXOBQIDAQABo4IBPjCC
15+
ATowCQYDVR0TBAIwADAOBgNVHQ8BAf8EBAMCB4AwEwYDVR0lBAwwCgYIKwYBBQUH
16+
AwMwYQYDVR0gBFowWDBWBgZngQwBBAEwTDAjBggrBgEFBQcCARYXaHR0cHM6Ly9k
17+
LnN5bWNiLmNvbS9jcHMwJQYIKwYBBQUHAgIwGQwXaHR0cHM6Ly9kLnN5bWNiLmNv
18+
bS9ycGEwHwYDVR0jBBgwFoAUljtT8Hkzl699g+8uK8zKt4YecmYwKwYDVR0fBCQw
19+
IjAgoB6gHIYaaHR0cDovL3N2LnN5bWNiLmNvbS9zdi5jcmwwVwYIKwYBBQUHAQEE
20+
SzBJMB8GCCsGAQUFBzABhhNodHRwOi8vc3Yuc3ltY2QuY29tMCYGCCsGAQUFBzAC
21+
hhpodHRwOi8vc3Yuc3ltY2IuY29tL3N2LmNydDANBgkqhkiG9w0BAQsFAAOCAQEA
22+
I/j/PcCNPebSAGrcqSFBSa2mmbusOX01eVBg8X0G/z8Z+ZWUfGFzDG0GQf89MPxV
23+
woec+nZuqui7o9Bg8s8JbHV0TC52X14CbTj9w/qBF748WbH9gAaTkrJYPm+MlNhu
24+
tjEuQdNl/YXVMvQW4O8UMHTi09GyJQ0NC4q92Wxvx1m/qzjvTLvrXHGQ9pEHhPyz
25+
vfBLxQkWpNoCNKU7UeESyH06XOrGc9MsII9deeKsDJp9a0jtx+pP4MFVtFME9SSQ
26+
tMBs0It7WwEf7qcRLpialxKwY2EzQ9g4WnANHqo18PrDBE10TFpZPzUh7JhMViVr
27+
EEbl0YdElmF8Hlamah/yNw==
28+
-----END CERTIFICATE-----

src/Adapters/Auth/gcenter.js

+1
Original file line numberDiff line numberDiff line change
@@ -133,4 +133,5 @@ function validateAppId() {
133133
module.exports = {
134134
validateAppId,
135135
validateAuthData,
136+
cache,
136137
};

0 commit comments

Comments
 (0)