Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockup for photo and video attribution in reader slideshow #895

Open
jesicarson opened this issue Aug 23, 2018 · 6 comments
Open

Mockup for photo and video attribution in reader slideshow #895

jesicarson opened this issue Aug 23, 2018 · 6 comments
Assignees
Labels

Comments

@jesicarson
Copy link
Member

For photos and videos if any of the attribution fields are filled in, there will be a black, semi-transparent overlay that appears on the slideshow image, and the user entered text for 'attribution' will be a hyperlink if they entered a link. Title/description will follow. So there won't be static text/labels showing on view for these, only user entered text.

@jesicarson jesicarson self-assigned this Aug 23, 2018
@jesicarson
Copy link
Member Author

Example of case with youtube and vimeo videos added: https://participedia.xyz/case/5009. Need to figure out how an overlay for attribution would work for videos on desktop, without interfering with the player.

image

@scottofletcher
Copy link

This looks great @jesicarson!

One question/request I have: is it possible to have a pop-out slideshow if you click on the image (even if there's just one image)? There are some images that get cut off but the only way to see the whole thing is to save it and open it in w/a desktop app.

I'm thinking something like Twitter when you click on attached media:

Regular Tweet:
image

Click on Image:
image

Mouse-over Image:
image

@scottofletcher
Copy link

Oh and the same thing works for slideshows:

Regular Tweet
image

Click on image:
image

Slideshow:
image

@jesicarson
Copy link
Member Author

Thanks @scottofletcher , full screen might be an option yes. I think the slideshow on desktop was meant to be that, essentially though. But that's not good that its cutting things off - can you send me an example of a case with a cut off image so I can share with dethe when we talk about this tomorrow? Thanks!

@scottofletcher
Copy link

@jesicarson Here's one with a cut off image: https://participedia.xyz/case/4947
If you save the image, you can see that's there's more to it (ie. the bottom 1/5 is cut off). There are loads more like this - any image that's not landscape gets the bottom lopped off. Most (basically all) pictures from Instagram are, therefore, a problem.

@jesicarson
Copy link
Member Author

Yep definitely a problem with the slideshow format as it is. The only images that should be cropped are the lead image if it is needed to fit the homepage thumnail format. The rest of the images should show up un-cropped in the slideshow. I'm going to do a mockup for this anyway so I'll make sure to specify that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants