fix: printing gvkparser error message (argoproj#585)

pgier · web-flow · commit 0be58f261add · 2024-06-25T14:53:55.000-04:00
The log.Info function doesn't understand format directives, so use key/value to print error message.

Signed-off-by: Paul Gier &lt;paul.gier@datastax.com&gt;
diff --git a/pkg/cache/cluster.go b/pkg/cache/cluster.go
@@ -711,7 +711,7 @@ func (c *clusterCache) watchEvents(ctx context.Context, api kube.APIResourceInfo
 							if !ok {
 								return err
 							}
-							c.log.Info("warning loading openapi schema: %s", e)
+							c.log.Info("warning: failed to create gvk parser", "error", e.Error())
 						}
 						if gvkParser != nil {
 							c.gvkParser = gvkParser
@@ -825,7 +825,7 @@ func (c *clusterCache) sync() error {
 		if !ok {
 			return err
 		}
-		c.log.Info("warning loading openapi schema: %s", e.Error())
+		c.log.Info("warning: failed to create gvk parser", "error", e.Error())
 	}
 
 	if gvkParser != nil {

Original file line number	Diff line number	Diff line change
`@@ -711,7 +711,7 @@ func (c *clusterCache) watchEvents(ctx context.Context, api kube.APIResourceInfo`
`711`	`711`	`if !ok {`
`712`	`712`	`return err`
`713`	`713`	`}`
`714`		`- c.log.Info("warning loading openapi schema: %s", e)`
	`714`	`+ c.log.Info("warning: failed to create gvk parser", "error", e.Error())`
`715`	`715`	`}`
`716`	`716`	`if gvkParser != nil {`
`717`	`717`	`c.gvkParser = gvkParser`
`@@ -825,7 +825,7 @@ func (c *clusterCache) sync() error {`
`825`	`825`	`if !ok {`
`826`	`826`	`return err`
`827`	`827`	`}`
`828`		`- c.log.Info("warning loading openapi schema: %s", e.Error())`
	`828`	`+ c.log.Info("warning: failed to create gvk parser", "error", e.Error())`
`829`	`829`	`}`
`830`	`830`
`831`	`831`	`if gvkParser != nil {`