fix: Dry run stuck on pre sync hook (argoproj#236)

* fix: Dry run stuck on pre sync hook

Signed-off-by: May Zhang <[email protected]>

* fix: Dry run stuck on pre sync hook

Signed-off-by: May Zhang <[email protected]>

Author: mayzhang2000

pkg/sync/sync_context.go

@@ -1060,7 +1060,13 @@ func (sc *syncContext) processCreateTasks(state runState, tasks syncTasks, dryRu
 				state = failed
 			}
 			if !dryRun || sc.dryRun || result == common.ResultCodeSyncFailed {
-				sc.setResourceResult(t, result, operationPhases[result], message)
+				phase := operationPhases[result]
+				// no resources are created in dry-run, so running phase means validation was
+				// successful and sync operation succeeded
+				if sc.dryRun && phase == common.OperationRunning {
+					phase = common.OperationSucceeded
+				}
+				sc.setResourceResult(t, result, phase, message)
 			}
 			return state
 		})