Skip to content

Commit 55bb494

Browse files
jsorefcrenshaw-dev
andauthored
chore: Spelling (argoproj#215)
* spelling: account Signed-off-by: Josh Soref <[email protected]> * spelling: aggregation Signed-off-by: Josh Soref <[email protected]> * spelling: annotations Signed-off-by: Josh Soref <[email protected]> * spelling: argocd Signed-off-by: Josh Soref <[email protected]> * spelling: does-not Signed-off-by: Josh Soref <[email protected]> * spelling: donot Signed-off-by: Josh Soref <[email protected]> * spelling: do-not Signed-off-by: Josh Soref <[email protected]> * spelling: implementers Signed-off-by: Josh Soref <[email protected]> * spelling: individual Signed-off-by: Josh Soref <[email protected]> * spelling: openshift Signed-off-by: Josh Soref <[email protected]> * spelling: relate Signed-off-by: Josh Soref <[email protected]> * spelling: requeuing Signed-off-by: Josh Soref <[email protected]> * spelling: settings Signed-off-by: Josh Soref <[email protected]> * spelling: worse Signed-off-by: Josh Soref <[email protected]> * spelling: youtube Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
1 parent d8b1a12 commit 55bb494

11 files changed

+22
-22
lines changed

pkg/cache/cluster.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -972,7 +972,7 @@ func (c *clusterCache) processEvent(event watch.EventType, un *unstructured.Unst
972972
h(event, un)
973973
}
974974
key := kube.GetResourceKey(un)
975-
if event == watch.Modified && skipAppRequeing(key) {
975+
if event == watch.Modified && skipAppRequeuing(key) {
976976
return
977977
}
978978

@@ -1044,8 +1044,8 @@ func (c *clusterCache) GetClusterInfo() ClusterInfo {
10441044
}
10451045
}
10461046

1047-
// skipAppRequeing checks if the object is an API type which we want to skip requeuing against.
1047+
// skipAppRequeuing checks if the object is an API type which we want to skip requeuing against.
10481048
// We ignore API types which have a high churn rate, and/or whose updates are irrelevant to the app
1049-
func skipAppRequeing(key kube.ResourceKey) bool {
1049+
func skipAppRequeuing(key kube.ResourceKey) bool {
10501050
return ignoredRefreshResources[key.Group+"/"+key.Kind]
10511051
}

pkg/cache/resource_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ metadata:
5252
assert.False(t, parent.isParentOf(nonMatchingNameEndPoint))
5353
}
5454

55-
func TestIsServiceAccoountParentOfSecret(t *testing.T) {
55+
func TestIsServiceAccountParentOfSecret(t *testing.T) {
5656
serviceAccount := c.newResource(strToUnstructured(`
5757
apiVersion: v1
5858
kind: ServiceAccount

pkg/diff/diff.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -391,8 +391,8 @@ func GetLastAppliedConfigAnnotation(live *unstructured.Unstructured) (*unstructu
391391
if live == nil {
392392
return nil, nil
393393
}
394-
annots := live.GetAnnotations()
395-
lastAppliedStr, ok := annots[corev1.LastAppliedConfigAnnotation]
394+
annotations := live.GetAnnotations()
395+
lastAppliedStr, ok := annotations[corev1.LastAppliedConfigAnnotation]
396396
if !ok {
397397
return nil, nil
398398
}
@@ -554,7 +554,7 @@ func normalizeRole(un *unstructured.Unstructured, o options) {
554554
if ok {
555555
_, ok = aggrIf.(map[string]interface{})
556556
if !ok {
557-
o.log.Info(fmt.Sprintf("Malformed aggregrationRule in resource '%s', won't modify.", un.GetName()))
557+
o.log.Info(fmt.Sprintf("Malformed aggregationRule in resource '%s', won't modify.", un.GetName()))
558558
} else {
559559
un.Object["rules"] = nil
560560
}

pkg/health/health.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ var healthOrder = []HealthStatusCode{
4747
HealthStatusUnknown,
4848
}
4949

50-
// IsWorse returns whether or not the new health status code is a worser condition than the current
50+
// IsWorse returns whether or not the new health status code is a worse condition than the current
5151
func IsWorse(current, new HealthStatusCode) bool {
5252
currentIndex := 0
5353
newIndex := 0

pkg/health/testdata/pod-deletion.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ metadata:
1010
deletionTimestamp: 2018-12-03T10:16:04Z
1111
spec:
1212
containers:
13-
- image: doesnt-exist
13+
- image: does-not-exist
1414
imagePullPolicy: Always
1515
name: main
1616
resources: {}
@@ -59,7 +59,7 @@ status:
5959
status: "True"
6060
type: PodScheduled
6161
containerStatuses:
62-
- image: doesnt-exist
62+
- image: does-not-exist
6363
imageID: ""
6464
lastState: {}
6565
name: main

pkg/health/testdata/pod-pending.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ metadata:
99
uid: 46c1e8de-f61b-11e8-a057-fe5f49266390
1010
spec:
1111
containers:
12-
- image: doesnt-exist
12+
- image: does-not-exist
1313
imagePullPolicy: Always
1414
name: main
1515
resources: {}
@@ -58,7 +58,7 @@ status:
5858
status: "True"
5959
type: PodScheduled
6060
containerStatuses:
61-
- image: doesnt-exist
61+
- image: does-not-exist
6262
imageID: ""
6363
lastState: {}
6464
name: main

pkg/sync/sync_context_test.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -455,13 +455,13 @@ func TestSyncPruneFailure(t *testing.T) {
455455
assert.Equal(t, "foo", result.Message)
456456
}
457457

458-
func TestDontSyncOrPruneHooks(t *testing.T) {
458+
func TestDoNotSyncOrPruneHooks(t *testing.T) {
459459
syncCtx := newTestSyncCtx(WithOperationSettings(false, false, false, true))
460460
targetPod := NewPod()
461-
targetPod.SetName("dont-create-me")
461+
targetPod.SetName("do-not-create-me")
462462
targetPod.SetAnnotations(map[string]string{synccommon.AnnotationKeyHook: "PreSync"})
463463
liveSvc := NewService()
464-
liveSvc.SetName("dont-prune-me")
464+
liveSvc.SetName("do-not-prune-me")
465465
liveSvc.SetNamespace(FakeArgoCDNamespace)
466466
liveSvc.SetAnnotations(map[string]string{synccommon.AnnotationKeyHook: "PreSync"})
467467

@@ -473,7 +473,7 @@ func TestDontSyncOrPruneHooks(t *testing.T) {
473473
}
474474

475475
// make sure that we do not prune resources with Prune=false
476-
func TestDontPrunePruneFalse(t *testing.T) {
476+
func TestDoNotPrunePruneFalse(t *testing.T) {
477477
syncCtx := newTestSyncCtx(WithOperationSettings(false, true, false, false))
478478
pod := NewPod()
479479
pod.SetAnnotations(map[string]string{synccommon.AnnotationSyncOptions: "Prune=false"})
@@ -1250,7 +1250,7 @@ func TestPruneLast(t *testing.T) {
12501250
assert.Equal(t, 3, tasks.lastWave())
12511251
})
12521252

1253-
t.Run("pruneLastIndidualResources", func(t *testing.T) {
1253+
t.Run("pruneLastIndividualResources", func(t *testing.T) {
12541254
syncCtx.pruneLast = false
12551255

12561256
pod1.SetAnnotations(map[string]string{synccommon.AnnotationSyncWave: "2"})

pkg/sync/sync_task_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func Test_syncTask_deleteBeforeCreation(t *testing.T) {
6464
// must be hook
6565
assert.False(t, (&syncTask{liveObj: Annotate(NewPod(), "argocd.argoproj.io/hook-delete-policy", "BeforeHookCreation")}).deleteBeforeCreation())
6666
// no need to delete if no live obj
67-
assert.False(t, (&syncTask{targetObj: Annotate(Annotate(NewPod(), "argoocd.argoproj.io/hook", "Sync"), "argocd.argoproj.io/hook-delete-policy", "BeforeHookCreation")}).deleteBeforeCreation())
67+
assert.False(t, (&syncTask{targetObj: Annotate(Annotate(NewPod(), "argocd.argoproj.io/hook", "Sync"), "argocd.argoproj.io/hook-delete-policy", "BeforeHookCreation")}).deleteBeforeCreation())
6868
assert.True(t, (&syncTask{liveObj: Annotate(Annotate(NewPod(), "argocd.argoproj.io/hook", "Sync"), "argocd.argoproj.io/hook-delete-policy", "BeforeHookCreation")}).deleteBeforeCreation())
6969
assert.True(t, (&syncTask{liveObj: Annotate(Annotate(NewPod(), "argocd.argoproj.io/hook", "Sync"), "argocd.argoproj.io/hook-delete-policy", "BeforeHookCreation")}).deleteBeforeCreation())
7070

specs/design-bottom-up.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Resources of the deprecated extensions API group have duplicates in groups apps,
5757
* The ReplicaSet from apps group might reference Deployment from the extensions group as a parent.
5858
* The relationship between Service and Endpoint is not explicit: [kubernetes/#28483](https://github.com/kubernetes/kubernetes/issues/28483)
5959
* The relationship between ServiceAccount and Token is not explicit.
60-
* Resources of Openshift deprecated groups authorization.openshift.io and project.openshift.io create
60+
* Resources of OpenShift deprecated groups authorization.openshift.io and project.openshift.io create
6161
duplicates in rbac.authorization.k8s.io and core groups.
6262

6363
#### Top-Level Component APIs

specs/design-top-down.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ type Sync<Term>Store interface {
178178
type ReconciliationSettings struct {
179179
// AppInstanceLabelKey holds label key which is automatically added to every resource managed by the application
180180
AppInstanceLabelKey string
181-
// ResourcesFilter holds settigns which allows to configure list of managed resource APIs
181+
// ResourcesFilter holds settings which allows to configure list of managed resource APIs
182182
ResourcesFilter resource.ResourcesFilter
183183
// ResourceOverrides holds settings which customize resource diffing logic
184184
ResourceOverrides map[scheme.GroupKind]appv1.ResourceOverride

specs/template.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ The title should be lowercased and spaces/punctuation should be replaced with
1717
The `Summary` section is incredibly important for producing high quality
1818
user-focused documentation such as release notes or a development roadmap. It
1919
should be possible to collect this information before implementation begins in
20-
order to avoid requiring implementors to split their attention between writing
20+
order to avoid requiring implementers to split their attention between writing
2121
release notes and implementing the feature itself. Ensure that the tone and
2222
content of the `Summary` section is useful for a wide audience.
2323

@@ -51,7 +51,7 @@ bogged down.
5151

5252
What are the caveats to the implementation? What are some important details
5353
that didn't come across above. Go in to as much detail as necessary here.
54-
This might be a good place to talk about core concepts and how they releate.
54+
This might be a good place to talk about core concepts and how they relate.
5555

5656
### Risks and Mitigations
5757

0 commit comments

Comments
 (0)