Skip to content

Commit 61c0cc7

Browse files
fix: Add missing IngressClass in kind order when syncing tasks (argoproj#380)
Signed-off-by: Yuan Tang <[email protected]>
1 parent 553ae80 commit 61c0cc7

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pkg/sync/sync_tasks.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var syncPhaseOrder = map[common.SyncPhase]int{
2020
}
2121

2222
// kindOrder represents the correct order of Kubernetes resources within a manifest
23-
// https://github.com/helm/helm/blob/146e0f9cc3b9c7ca9cb9dd0eba12de2270ae6faf/pkg/releaseutil/kind_sorter.go
23+
// https://github.com/helm/helm/blob/0361dc85689e3a6d802c444e2540c92cb5842bc9/pkg/releaseutil/kind_sorter.go
2424
var kindOrder = map[string]int{}
2525

2626
func init() {
@@ -57,6 +57,7 @@ func init() {
5757
"StatefulSet",
5858
"Job",
5959
"CronJob",
60+
"IngressClass",
6061
"Ingress",
6162
"APIService",
6263
}

pkg/sync/sync_tasks_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313
)
1414

1515
func Test_syncTasks_kindOrder(t *testing.T) {
16-
assert.Equal(t, -34, kindOrder["Namespace"])
16+
assert.Equal(t, -35, kindOrder["Namespace"])
1717
assert.Equal(t, -1, kindOrder["APIService"])
1818
assert.Equal(t, 0, kindOrder["MyCRD"])
1919
}

0 commit comments

Comments
 (0)