Skip to content

Commit 73bcea9

Browse files
authored
fix: Set QPS and burst rate for resource ops client (argoproj#395)
Signed-off-by: jannfis <[email protected]>
1 parent 723667d commit 73bcea9

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

pkg/utils/kube/ctl.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,14 +208,14 @@ func (k *KubectlCmd) DeleteResource(ctx context.Context, config *rest.Config, gv
208208
func (k *KubectlCmd) ManageResources(config *rest.Config, openAPISchema openapi.Resources) (ResourceOperations, func(), error) {
209209
f, err := ioutil.TempFile(utils.TempDir, "")
210210
if err != nil {
211-
return nil, nil, fmt.Errorf("Failed to generate temp file for kubeconfig: %v", err)
211+
return nil, nil, fmt.Errorf("failed to generate temp file for kubeconfig: %v", err)
212212
}
213213
_ = f.Close()
214214
err = WriteKubeConfig(config, "", f.Name())
215215
if err != nil {
216-
return nil, nil, fmt.Errorf("Failed to write kubeconfig: %v", err)
216+
return nil, nil, fmt.Errorf("failed to write kubeconfig: %v", err)
217217
}
218-
fact := kubeCmdFactory(f.Name(), "")
218+
fact := kubeCmdFactory(f.Name(), "", config)
219219
cleanup := func() {
220220
utils.DeleteFile(f.Name())
221221
}

pkg/utils/kube/resource_ops.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,14 @@ func (k *kubectlResourceOperations) runResourceCommand(ctx context.Context, obj
131131
return strings.Join(out, ". "), nil
132132
}
133133

134-
func kubeCmdFactory(kubeconfig, ns string) cmdutil.Factory {
134+
func kubeCmdFactory(kubeconfig, ns string, config *rest.Config) cmdutil.Factory {
135135
kubeConfigFlags := genericclioptions.NewConfigFlags(true)
136136
if ns != "" {
137137
kubeConfigFlags.Namespace = &ns
138138
}
139139
kubeConfigFlags.KubeConfig = &kubeconfig
140+
kubeConfigFlags.WithDiscoveryBurst(config.Burst)
141+
kubeConfigFlags.WithDiscoveryQPS(config.QPS)
140142
matchVersionKubeConfigFlags := cmdutil.NewMatchVersionFlags(kubeConfigFlags)
141143
return cmdutil.NewFactory(matchVersionKubeConfigFlags)
142144
}

0 commit comments

Comments
 (0)