Skip to content

Commit 12be0e6

Browse files
authored
Fix health check failures not notifying (#61)
1 parent e7d12c9 commit 12be0e6

File tree

4 files changed

+7
-13
lines changed

4 files changed

+7
-13
lines changed

Diff for: .github/workflows/health_check.yml

+3-8
Original file line numberDiff line numberDiff line change
@@ -7,30 +7,25 @@ jobs:
77
build-and-test:
88
name: Run tests
99
runs-on: ubuntu-latest
10-
strategy:
11-
matrix:
12-
ruby: ['2.7.1']
1310
steps:
1411
- name: Check out code
1512
uses: actions/checkout@v2
1613

1714
- name: Setup Ruby
1815
uses: ruby/setup-ruby@v1
1916
with:
20-
ruby-version: ${{ matrix.ruby }}
21-
22-
- name: Install Ruby Dependencies
23-
run: bundle install
17+
ruby-version: 3.0.2
18+
bundler-cache: true
2419

2520
- name: Run tests
2621
env:
2722
SANDBOX_API_KEY: ${{ secrets.SANDBOX_API_KEY }}
2823
run: make test
2924

3025
- name: Notify slack
26+
if: failure()
3127
uses: kpritam/slack-job-status-action@v1
3228
with:
33-
if: failure()
3429
job-status: ${{ job.status }}
3530
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
3631
channel: eng-notifications

Diff for: .github/workflows/test.yml

+2-4
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212

1313
strategy:
1414
matrix:
15-
ruby-version: [3.0.1, 2.7.4, 2.6.8]
15+
ruby-version: [3.0.2, 2.7.4, 2.6.8]
1616
max-parallel: 1
1717

1818
steps:
@@ -23,9 +23,7 @@ jobs:
2323
uses: ruby/setup-ruby@v1
2424
with:
2525
ruby-version: ${{ matrix.ruby-version }}
26-
27-
- name: Install Ruby Dependencies
28-
run: bundle install
26+
bundler-cache: true
2927

3028
- name: Build Gem
3129
run: gem build -o patch_ruby.gem patch_ruby.gemspec

Diff for: Gemfile.lock

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ PLATFORMS
7373
arm64-darwin-20
7474
arm64-darwin-21
7575
x86_64-darwin-20
76+
x86_64-linux
7677

7778
DEPENDENCIES
7879
factory_bot (~> 6.2)

Diff for: spec/integration/estimates_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
)
2828

2929
expect(flight_estimate.data.type).to eq 'flight'
30-
expect(flight_estimate.data.mass_g).to eq 1_000_622
30+
expect(flight_estimate.data.mass_g).to be >= 1_000_000
3131
end
3232

3333
it 'supports creating flight estimates with origin and destination' do

0 commit comments

Comments
 (0)