Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touch compatibility #31

Open
MacroMachines opened this issue Feb 24, 2018 · 2 comments
Open

touch compatibility #31

MacroMachines opened this issue Feb 24, 2018 · 2 comments

Comments

@MacroMachines
Copy link

I love this glsl editor, the widgets that come up when editing different values are absolutely brilliant and I hope more people reference it and incorporate that idea. I have been writing alot of shaders using my iPad Pro and sadly the widgets don't work with touch. I tried to see if I could add touch capability myself but I couldn't quite pin down where in the many tens of thousands of lines of code. I have found in general that touch works fine in other projects by copying mouse events and replacing the touch equivalent, and adding event.preventDefault().

Also would be amazing if you offered the widget/code popups as a separate repo/extension to codemirror.

Amazing work, Ive shown the book of shaders to like >10 people since I found it and I genuinely feel it is the best learning resource I have ever seen, not just for glsl but in general. Cheers!

@ChronoAndross
Copy link

@MacroMachines ,
I've worked with some of the UI in this code base before, so maybe I can take a look at this for you.

@patriciogonzalezvivo is this something that you envision the editor being fully compatible with mobile as well? I can look into it if you wish.

@patriciogonzalezvivo
Copy link
Owner

Thanks @MacroMachines! definitely I have in my todo's to make a separate npm package with the UI "pickers".

Any work to make the editor work better on iOS devices or other mobile browsers is super welcome!
Only things to have in mind: I'm supporting the possibility of running the editor offline and "natively" using electron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants