Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export to Openframe not working #49

Open
jvolker opened this issue Aug 18, 2019 · 6 comments
Open

Export to Openframe not working #49

jvolker opened this issue Aug 18, 2019 · 6 comments

Comments

@jvolker
Copy link

jvolker commented Aug 18, 2019

When clicking Artwork to [o] button the shader doesn't show up in Openframe.

The console throws these errors:

Modal.js:87 Uncaught TypeError: Cannot read property 'classList' of null
    at ExportModal.onClickOutside (Modal.js:87)
    at HTMLBodyElement.handler (Modal.js:118)
onClickOutside @ Modal.js:87
handler @ Modal.js:118
VM77:1 POST https://thebookofshaders.com:8080/save net::ERR_CERT_AUTHORITY_INVALID

Thanks for any help with fixing this.

@jmwohl
Copy link
Contributor

jmwohl commented Aug 18, 2019

Seems like maybe just serving the editor via https might fix this?

@jmwohl
Copy link
Contributor

jmwohl commented Aug 18, 2019

Oh — seems like it is/was, but the SSL cert isn't valid anymore. Updating that should fix it (maybe).

@patriciogonzalezvivo
Copy link
Owner

That's true. I need a hand for that SSL keys are not my thing

@jmwohl
Copy link
Contributor

jmwohl commented Aug 18, 2019

Happy to help @patriciogonzalezvivo! Depending on how you're hosting this, it might be as simple as a one-click install from your host — most offer SSL for free now that Let'sEncrypt is around.

@patriciogonzalezvivo
Copy link
Owner

patriciogonzalezvivo commented Aug 18, 2019 via email

@jmwohl
Copy link
Contributor

jmwohl commented Aug 19, 2019

Sure — I've never manually set up a cert like that with node, always used a reverse proxy server in front of node application. But it should work fine as you have it, probably just need to update the cert? @patriciogonzalezvivo if you're still on slack at all, we can connect on the Openframe slack channel, or shoot me an email and I can try to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants