ssh askpass prompt

[mboekhold]

The fallback ssh askpass prompt for the username entry appears as asterisks. I'm wondering if we can change that to only appear for the password entry. this just adds to the usability a tiny bit, as I occasionally fat finger my username sometimes 😅

[davvid]

FYI I have a copy of the ssh-askpass in https://github.com/git-cola/git-cola/ that originated from the script in this project. Someone recently submitted a change that added a toggle checkbox, which is basically the feature request here.

I've been meaning to get this back upstream (along with other patches that touched that file). For this feature, this was the relevant commit:

git-cola/git-cola@f1a8358

One note -- It seems like our shebang lines have diverged. I don't know why. I'm not a tcl/tk/wish expert so I'd defer to the copy in the git-gui repo, personally.

@fmoralesc can you explain whether #!/usr/bin/env tclsh is better than the #!/bin/sh trick which ends up doing exec wish ? I don't know enough to judge tclsh vs. wish. I guess that change should have been made here in the first place.

In any case, I've opened a PR with all of the interesting commits from git-cola here:

prati0100/git-gui#38

It basically implements this feature, so I think this issue can be closed and tracked over there.

[fmoralesc]

@davvid For some reason, at the time in my system sh would not interpret the file correctly unless the proper interpreter was given, so I decided to be more explicit. (Now, at this point I also have problems with the git-cola (3.6) provided ssh-askpass; at some point the syntax of the file broke. I get this problem regardless of the shebang. But that's a separate problem.)

[davvid]

We've fixed it since then ;-)

[fmoralesc]

I guessed, that's why I mentioned the version ;) (EDIT: turned out I had installed the git version but had forgotten to update since then... :p)

[davvid]

Heh, the fix was entertaining tho. git-cola/git-cola@cca03e3

I thought python was the only one that had whitespace code bugs ;-) but I got to learn that tcl has similar sharp edges in certain versions. When I transplanted the commits over I made sure to not include that buglet. As always, it's best to have these fixes upstream.

I've spammed this issue enough, though. cheers.

[davvid]

This patch has been submitted upstream to the GIt core development list for the new maintainer. BTW, the current git-gui maintainer's fork is here:

https://github.com/prati0100/git-gui

This PR can be closed now (or maybe wait until the patch is acknowledged and accepted).

https://public-inbox.org/git/20201107222039.13900-1-davvid@gmail.com/T/#u