Skip to content

Commit 3cfc54c

Browse files
Merge pull request #143 from pauldmccarthy/ci/fix-builds
MNT: Remove numpy as a build-time dependency
2 parents a09f2e2 + f3197cc commit 3cfc54c

File tree

7 files changed

+1176
-1343
lines changed

7 files changed

+1176
-1343
lines changed

.ci/build_wheels.sh

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,26 +21,27 @@ export CIBW_TEST_REQUIRES="cython pytest numpy nibabel coverage cython-coverage
2121
# history [GHA logs of failing builds deleted]).
2222
export CIBW_SKIP="pp*"
2323

24-
# Make sure numpy can be built without BLAS being present
25-
# (it may end up being built from source on some platforms)
26-
# https://github.com/numpy/numpy/issues/24703#issuecomment-1722379388
27-
export PIP_CONFIG_SETTINGS='setup-args="-Dallow-noblas=true"'
28-
29-
# Skip i686 tests - I have experienced hangs on these
30-
# platforms, which I traced to a trivial numpy operation -
31-
# "numpy.linalg.det(numpy.eye(3))". This occurs when numpy
32-
# has to be compiled from source during the build, so can
33-
# be re-visited if/when numpy is avaialble on all platforms.
24+
# Skip i686 and aarch64 tests
25+
26+
# - I have experienced hangs on these platforms,
27+
# which I traced to a trivial numpy operation -
28+
# "numpy.linalg.det(numpy.eye(3))".
29+
30+
# - Numpy wheels are not available for these
31+
# platforms, so has to be compiled from source
32+
# during the build, which massively increases
33+
# build time and complexity.
3434
#
35-
# Skip py312 tests on Windows due to unresolved test failures.
36-
export CIBW_TEST_SKIP="*i686* cp312-win*"
35+
# Skip py312 tests on Windows due to unresolved
36+
# test failures.
37+
export CIBW_TEST_SKIP="*i686* *aarch64* cp312-win*"
3738

3839
# Pytest makes it *very* awkward to run tests
3940
# from an installed package, and still find/
4041
# interpret a conftest.py file correctly.
41-
echo '#!/usr/bin/env bash' > testcmd
42-
echo 'cp $1/pyproject.toml .' >> testcmd
43-
echo 'python -m indexed_gzip.tests -c pyproject.toml --no-cov -m "not slow_test"' >> testcmd
42+
echo '#!/usr/bin/env bash' > testcmd
43+
echo 'cp $1/pyproject.toml .' >> testcmd
44+
echo 'python -m indexed_gzip.tests -c pyproject.toml --no-cov -m "not slow_test" -k "not test_zran"' >> testcmd
4445
chmod a+x testcmd
4546

4647
export CIBW_TEST_COMMAND="bash {project}/testcmd {project}"

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
# `indexed_gzip` changelog
22

33

4-
## 1.8.7 (November 2nd 2023)
4+
## 1.8.7 (November 6th 2023)
55

66

77
* Enable Python 3.12 and `musllinux` builds (#139).
8+
* Remove `numpy` as a mandatory build-time dependency (#142, #143).
89

910

1011
## 1.8.5 (August 29th 2023)

0 commit comments

Comments
 (0)