Use named constants to enable/disable/toggle warnings, instead of hardcoded values

Author: Daniel-Cortez

source/compiler/sc.h

@@ -539,6 +539,12 @@ typedef enum s_optmark {
 
 #define MAX_INSTR_LEN   30
 
+typedef enum s_warnmode {
+  warnDISABLE,
+  warnENABLE,
+  warnTOGGLE
+} warnmode;
+
 #define eotNUMBER       0
 #define eotFUNCTION     1
 #define eotLABEL        2
@@ -607,7 +613,7 @@ enum { /* attribute flags for "__pragma" */
 int pc_compile(int argc, char **argv);
 int pc_addconstant(char *name,cell value,int tag);
 int pc_addtag(char *name);
-int pc_enablewarning(int number,int enable);
+int pc_enablewarning(int number,warnmode enable);
 int pc_pushwarnings();
 int pc_popwarnings();
 void pc_seterrorwarnings(int enable);

source/compiler/sc1.c

@@ -1212,11 +1212,11 @@ static void parseoptions(int argc,char **argv,char *oname,char *ename,char *pnam
       case 'w':
         i=(int)strtol(option_value(ptr),(char **)&ptr,10);
         if (*ptr=='-')
-          pc_enablewarning(i,0);
+          pc_enablewarning(i,warnDISABLE);
         else if (*ptr=='+')
-          pc_enablewarning(i,1);
+          pc_enablewarning(i,warnENABLE);
         else if (*ptr=='\0')
-          pc_enablewarning(i,2);
+          pc_enablewarning(i,warnTOGGLE);
         break;
       case 'X':
         if (*(ptr+1)=='D') {

source/compiler/sc2.c

@@ -1309,7 +1309,7 @@ static int command(void)
               cell val;
               do {
                 preproc_expr(&val,NULL);
-                pc_enablewarning(val,(str[0]=='e') ? 1 : 0);
+                pc_enablewarning(val,(str[0]=='e') ? warnENABLE : warnDISABLE);
               } while (*lptr!='\0');
             } else if (strcmp(str,"push")==0) {
               pc_pushwarnings();

source/compiler/sc5.c

@@ -385,7 +385,7 @@ SC_FUNC void errorset(int code,int line)
  *  o  1 for enable
  *  o  2 for toggle
  */
-int pc_enablewarning(int number,int enable)
+int pc_enablewarning(int number,warnmode enable)
 {
   int index;
   unsigned char mask;
@@ -399,13 +399,13 @@ int pc_enablewarning(int number,int enable)
   index=number/8;
   mask=(unsigned char)(1 << (number%8));
   switch (enable) {
-  case 0:
+  case warnDISABLE:
     warnstack.disable[index] |= mask;
     break;
-  case 1:
+  case warnENABLE:
     warnstack.disable[index] &= (unsigned char)~mask;
     break;
-  case 2:
+  case warnTOGGLE:
     warnstack.disable[index] ^= mask;
     break;
   } /* switch */