Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Temporary Code for Non-NGN Institutions from VerifyAccount Controller #395

Open
OnahProsperity opened this issue Jan 22, 2025 · 2 comments

Comments

@OnahProsperity
Copy link
Collaborator

User Story
As a developer, I want to remove the temporary code for non-NGN institutions from the VerifyAccount controller so that the application can handle all institutions uniformly.

Acceptance Criteria
GIVEN the VerifyAccount controller,
WHEN the temporary code for non-NGN institutions is removed,
THEN the controller should handle all institutions uniformly without bypassing the verification logic for non-NGN institutions.

GIVEN the VerifyAccount controller,
WHEN queried with a non-NGN institution,
THEN the account verification logic should be applied, and the account should be verified with external providers.

Tech Details
Remove the following block of code from the VerifyAccount controller in index.go:

// TODO: Remove this after testing non-NGN institutions
if institution.Edges.FiatCurrency.Code != "NGN" {
    u.APIResponse(ctx, http.StatusOK, "success", "Account name was fetched successfully", "OK")
    return
}

Ensure that the account verification logic is applied to all institutions, regardless of their currency.

@Supa-mega
Copy link

Can I take care of this issue?

@ussyalfaks
Copy link

Can I attempt this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants