Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove All Tron Implementation from the Codebase #396

Open
OnahProsperity opened this issue Jan 22, 2025 · 2 comments
Open

Remove All Tron Implementation from the Codebase #396

OnahProsperity opened this issue Jan 22, 2025 · 2 comments

Comments

@OnahProsperity
Copy link
Collaborator

User Story
As a developer, I want to remove all Tron implementation from the codebase to streamline the application for light-scale use and ensure that the application only supports used blockchain networks.

Acceptance Criteria
GIVEN the codebase,
WHEN the Tron implementation is removed,
THEN the application should no longer contain any Tron-related code, including functions, methods, and configurations specific to Tron.

GIVEN the codebase,
WHEN the application is built and run,
THEN it should function correctly without any references to Tron.

Tech Details
Remove all functions and methods related to Tron, such as IndexTRC20Transfer, IndexOrderCreatedTron, IndexOrderSettledTron, and IndexOrderRefundedTron.
Remove any Tron-specific configurations and constants from the configuration files.
Ensure that any references to Tron in the codebase are removed or refactored to exclude Tron-related logic.

Open Questions
Are there any dependencies or third-party libraries that are only used for Tron and can be removed?
Are there any database schema changes required to remove Tron-related data?

Notes/Assumptions
Assume that the removal of Tron implementation will not affect other functionalities of the application.
Ensure the changes do not disrupt existing functionality.
Coordinate with the QA team to test the changes in a staging environment before deploying to production.
Any database schema related to Tron can be ignore

Reference

// IndexTRC20Transfer indexes transfers to the receive address for Tron network.
func (s *IndexerService) IndexTRC20Transfer(ctx context.Context, order *ent.PaymentOrder) error {
    // Tron-specific implementation
}

// IndexOrderCreatedTron indexes orders created in the Gateway contract for the Tron network.
func (s *IndexerService) IndexOrderCreatedTron(ctx context.Context, order *ent.PaymentOrder) error {
    // Tron-specific implementation
}

// IndexOrderSettledTron indexes orders settled in the Gateway contract for the Tron network.
func (s *IndexerService) IndexOrderSettledTron(ctx context.Context, order *ent.LockPaymentOrder) error {
    // Tron-specific implementation
}

// IndexOrderRefundedTron indexes orders settled in the Gateway contract for the Tron network.
func (s *IndexerService) IndexOrderRefundedTron(ctx context.Context, order *ent.LockPaymentOrder) error {
    // Tron-specific implementation
}
@Supa-mega
Copy link

Can I handle this task?

@DevMukhtarr
Copy link

DevMukhtarr commented Feb 26, 2025

Hi @OnahProsperity I would like to take on the task of removing all Tron-related implementations from the codebase, I understand the importance of doing this as they are no longer needed in the application and this will help in streamlining the application.

Below, I outline my approach to addressing the requirements and ensuring a smooth transition:

  1. Codebase Analysis:
  • I will thoroughly review the codebase to identify all Tron-related functions, methods, configurations, and constants, such as IndexTRC20Transfer, IndexOrderCreatedTron,IndexOrderSettledTron, and IndexOrderRefundedTron.
  • I will check from all TRON specific configurations
  1. Dependency Review :
  • I will check for any third party libraries or dependencies that are exclusively used for Tron functionality
  1. Code Removal and Refactoring:
  • I will remove all Tron-related code and refactor any references to Tron to ensure the application logic remains intact.
  1. Testing and Validation:
  • I will build and run the application to verify that it functions correctly without any Tron-related references.
  1. Documentation:
  • I will document the changes made, including a list of removed functions, methods, and configurations, to provide clarity for future development.

Assumptions

  • I assume that the database schema related to Tron can be ignored, as per the notes provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants