-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rate Slippage Per Token for Provider Orders #398
Labels
Comments
Let me handle this issue! |
May I handle this issue? first time contributor |
I'd like to handle this task. |
Would love to tackle this! |
@caxtonacollins Are you still gonna work on this? Or, should I reassign it? |
Can I jump on this task? |
Can I try solving this issue? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
User Story
As a provider, I want to set a slippage percentage for each token I offer, to have more granular control over price fluctuations and protect my margins per currency pair.
Acceptance Criteria
GIVEN a provider is updating a token's settings
WHEN they include a rate_slippage value
THEN the value is saved as a decimal on that ProviderOrderToken
GIVEN a provider retrieves their profile
WHEN viewing token details
THEN they can see the rate_slippage value for each token
GIVEN a provider configures a new token
WHEN no rate_slippage is specified
THEN it defaults to 0
GIVEN a provider configures a new token
WHEN the rate_slippage is more than 20% of the currency market rate
THEN it returns an error message
GIVEN a lock payment order is being assigned
WHEN checking rate matches with providers
THEN use the provider's token-specific slippage instead of hardcoded 0.5
Tech Details
Notes/Assumptions
Open Questions
The text was updated successfully, but these errors were encountered: