fixes lint complaints

Author: danzhaaspaypal

Demo/DemoUITests/DemoUITestsLaunchTests.swift

@@ -2,7 +2,7 @@ import XCTest
 
 final class DemoUITestsLaunchTests: XCTestCase {
 
-    override class var runsForEachTargetApplicationUIConfiguration: Bool {
+    override static var runsForEachTargetApplicationUIConfiguration: Bool {
 
         true
     }

Sources/PayPalMessages/PayPalMessageModalViewControllerModel.swift

@@ -203,8 +203,11 @@ class PayPalMessageModalViewControllerModel: NSObject, WKNavigationDelegate, WKS
 
     // Exposed internally for tests
     func flushUpdates() {
-        guard let jsonData = try? JSONEncoder().encode(self.makeConfig()),
-              let jsonString = String(data: jsonData, encoding: .utf8) else { return }
+        guard let jsonData = try? JSONEncoder().encode(self.makeConfig()) else {
+            log(.error, "Failed to encode configuration.", for: environment)
+            return
+        }
+        let jsonString = String(decoding: jsonData, as: UTF8.self)
 
         log(.debug, "Update props: \(jsonString)", for: environment)
 

Tests/PayPalMessagesTests/AnyCodableTests.swift

@@ -22,7 +22,7 @@ final class AnyCodableTests: XCTestCase {
         let encoder = JSONEncoder()
         let data = try encoder.encode(intValue)
 
-        let jsonString = String(data: data, encoding: .utf8)
+        let jsonString = String(decoding: data, as: UTF8.self)
         XCTAssertEqual(jsonString, "42")
     }
 
@@ -34,7 +34,7 @@ final class AnyCodableTests: XCTestCase {
         let encoder = JSONEncoder()
         let data = try encoder.encode(stringValue)
 
-        let jsonString = String(data: data, encoding: .utf8)
+        let jsonString = String(decoding: data, as: UTF8.self)
         XCTAssertEqual(jsonString, "\"Hello, World!\"")
     }
 
@@ -45,7 +45,7 @@ final class AnyCodableTests: XCTestCase {
         let encoder = JSONEncoder()
         let data = try encoder.encode(boolValue)
 
-        let jsonString = String(data: data, encoding: .utf8)
+        let jsonString = String(decoding: data, as: UTF8.self)
         XCTAssertEqual(jsonString, "true")
     }
 
@@ -56,7 +56,7 @@ final class AnyCodableTests: XCTestCase {
         let encoder = JSONEncoder()
         let data = try encoder.encode(nilValue)
 
-        let jsonString = String(data: data, encoding: .utf8)
+        let jsonString = String(decoding: data, as: UTF8.self)
         XCTAssertEqual(jsonString, "null")
     }
 }

Tests/PayPalMessagesTests/PayPalMessageResponseTests.swift

@@ -54,11 +54,12 @@ final class MessageResponseTests: XCTestCase {
             }
         }
         """
-            // swiftlint:disable force_unwrapping
-            .data(using: .utf8)!
+        guard let jsonData = json.data(using: .utf8) else {
+            fatalError("Failed to convert string to data")
+        }
 
         let decoder = JSONDecoder()
-        let messageResponse = try decoder.decode(MessageResponse.self, from: json)
+        let messageResponse = try decoder.decode(MessageResponse.self, from: jsonData)
 
         XCTAssertEqual(messageResponse.offerType, .payLaterLongTerm)
         XCTAssertEqual(messageResponse.productGroup, .payLater)

Tests/PayPalMessagesTests/ResponseErrorTests.swift

@@ -20,11 +20,12 @@ final class ResponseErrorTests: XCTestCase {
             "debug_id": "12345"
         }
         """
-            // swiftlint:disable force_unwrapping
-            .data(using: .utf8)!
+        guard let jsonData = json.data(using: .utf8) else {
+            fatalError("Failed to convert string to data")
+        }
 
         let decoder = JSONDecoder()
-        let responseError = try decoder.decode(ResponseError.self, from: json)
+        let responseError = try decoder.decode(ResponseError.self, from: jsonData)
 
         XCTAssertEqual(responseError.paypalDebugID, "12345")
         XCTAssertNil(responseError.issue)
@@ -45,11 +46,12 @@ final class ResponseErrorTests: XCTestCase {
             ]
         }
         """
-            // swiftlint:disable force_unwrapping
-            .data(using: .utf8)!
+        guard let jsonData = json.data(using: .utf8) else {
+            fatalError("Failed to convert string to data")
+        }
 
         let decoder = JSONDecoder()
-        let responseError = try decoder.decode(ResponseError.self, from: json)
+        let responseError = try decoder.decode(ResponseError.self, from: jsonData)
 
         XCTAssertEqual(responseError.paypalDebugID, "12345")
         XCTAssertEqual(responseError.issue, "TEST_ISSUE")