Allow for only upper or lower limits #394

seananderson · seananderson · commit 685e6236f5e2 · 2025-01-24T09:48:17.000-08:00
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: sdmTMB
 Title: Spatial and Spatiotemporal SPDE-Based GLMMs with 'TMB'
-Version: 0.6.0.9021
+Version: 0.6.0.9022
 Authors@R: c(
     person(c("Sean", "C."), "Anderson", , "sean@seananderson.ca",
            role = c("aut", "cre"),
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # sdmTMB (development version)
 
+* Allow for specifying only lower or upper limits. #394
+
 * Add vignette on multispecies models with sdmTMB (or any case where one wants
   additional spatial and or spatiotemporal fields by some group).
 
diff --git a/R/fit.R b/R/fit.R
@@ -1556,6 +1556,8 @@ set_limits <- function(tmb_obj, lower, upper, loc = NULL, silent = TRUE) {
       if (!silent) message("Setting lower limit for ", i_name, " to ",
         lower[[i_name]], ".")
     }
+  }
+  for (i_name in names(upper)) {
     if (i_name %in% names(.upper)) {
       .upper[names(.upper) %in% i_name] <- upper[[i_name]]
       if (!silent) message("Setting upper limit for ", i_name, " to ",
diff --git a/sdmTMB.Rproj b/sdmTMB.Rproj
@@ -1,4 +1,5 @@
 Version: 1.0
+ProjectId: 1e54a969-ff39-402d-83f4-c260f1f06bda
 
 RestoreWorkspace: No
 SaveWorkspace: No

Original file line number	Diff line number	Diff line change
`@@ -1556,6 +1556,8 @@ set_limits <- function(tmb_obj, lower, upper, loc = NULL, silent = TRUE) {`
`1556`	`1556`	`if (!silent) message("Setting lower limit for ", i_name, " to ",`
`1557`	`1557`	`lower[[i_name]], ".")`
`1558`	`1558`	`}`
	`1559`	`+ }`
	`1560`	`+ for (i_name in names(upper)) {`
`1559`	`1561`	`if (i_name %in% names(.upper)) {`
`1560`	`1562`	`.upper[names(.upper) %in% i_name] <- upper[[i_name]]`
`1561`	`1563`	`if (!silent) message("Setting upper limit for ", i_name, " to ",`