From 3f6e5f34b104c4986d4a6cb86e5f7f34e18ae553 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20P=C3=A1la?= Date: Tue, 16 Mar 2021 16:41:13 +0100 Subject: [PATCH 1/3] =?UTF-8?q?Aktualizace=20na=20fix=20false=20positive?= =?UTF-8?q?=20p=C5=99=C3=ADpad=C5=AF=20++?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- composer.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index a8cb6d4..1668232 100644 --- a/composer.json +++ b/composer.json @@ -3,8 +3,8 @@ "description": "Coding standard pro PeckaDesign", "require": { "php": "7.* || 8.*", - "squizlabs/php_codesniffer": "3.*", - "slevomat/coding-standard": "6.4.*", + "squizlabs/php_codesniffer": "dev-master as 3.5.99", + "slevomat/coding-standard": "dev-master as 6.4.99", "escapestudios/symfony2-coding-standard": "3.*" }, "license": "MIT", From f4a3980263af381d17d3697d6191e9a74db67980 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20P=C3=A1la?= Date: Mon, 8 Mar 2021 14:32:31 +0100 Subject: [PATCH 2/3] =?UTF-8?q?DeclareStrictType=20chceme=20na=20prvn?= =?UTF-8?q?=C3=ADm=20=C5=99=C3=A1dku?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/PeckaCodingStandardStrict/ruleset.xml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PeckaCodingStandardStrict/ruleset.xml b/src/PeckaCodingStandardStrict/ruleset.xml index 1879e3e..948c685 100644 --- a/src/PeckaCodingStandardStrict/ruleset.xml +++ b/src/PeckaCodingStandardStrict/ruleset.xml @@ -11,7 +11,11 @@ - + + + + + From 38fbd6cb78c2035b08bc5c3c8e0d5df48858c3c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20P=C3=A1la?= Date: Mon, 8 Mar 2021 14:32:49 +0100 Subject: [PATCH 3/3] =?UTF-8?q?Nevyu=C5=BEit=C3=A9=20private=20property=20?= =?UTF-8?q?hl=C3=ADd=C3=A1=20PHPStan?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Makefile | 1 - src/PeckaCodingStandard/ruleset.xml | 1 - .../Failure/Classes/UnusedPrivateElements.php | 19 -------------- .../Success/Classes/UnusedPrivateElements.php | 25 ------------------- 4 files changed, 46 deletions(-) delete mode 100644 tests/Failure/Classes/UnusedPrivateElements.php delete mode 100644 tests/Success/Classes/UnusedPrivateElements.php diff --git a/Makefile b/Makefile index 3d759a6..4123c2a 100644 --- a/Makefile +++ b/Makefile @@ -3,7 +3,6 @@ test: ./vendor/bin/phpcs --standard=src/PeckaCodingStandardStrict/ruleset.xml tests/Success/ ./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Arrays/TrailingArrayComma.php | tests/errorNumber.sh 1 ./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Classes/ClassConstantVisibility.php | tests/errorNumber.sh 1 - ./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Classes/UnusedPrivateElements.php | tests/errorNumber.sh 2 ./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Classes/PropertySpacing.php | tests/errorNumber.sh 2 ./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Classes/MethodSpacingSniff.php | tests/errorNumber.sh 2 ./vendor/bin/phpcs --standard=src/PeckaCodingStandard/ruleset.xml tests/Failure/Classes/ClassMemberSpacing.php | tests/errorNumber.sh 1 diff --git a/src/PeckaCodingStandard/ruleset.xml b/src/PeckaCodingStandard/ruleset.xml index b730f5a..52ee8bf 100644 --- a/src/PeckaCodingStandard/ruleset.xml +++ b/src/PeckaCodingStandard/ruleset.xml @@ -10,7 +10,6 @@ - diff --git a/tests/Failure/Classes/UnusedPrivateElements.php b/tests/Failure/Classes/UnusedPrivateElements.php deleted file mode 100644 index 629639d..0000000 --- a/tests/Failure/Classes/UnusedPrivateElements.php +++ /dev/null @@ -1,19 +0,0 @@ -element; - } - - - public function execute(): void - { - $this->hello(); - } - -}