Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env vars: Client details should not be optional #27

Open
rht opened this issue Oct 13, 2021 · 2 comments
Open

env vars: Client details should not be optional #27

rht opened this issue Oct 13, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@rht
Copy link
Contributor

rht commented Oct 13, 2021

In current master, the check for whether the DB is seeded is if (process.env.EAUTH_CLIENT_NAME && process.env.EAUTH_CLIENT_ID && process.env.EAUTH_CLIENT_SECRET && process.env.EAUTH_REDIRECT_URI). Which doesn't seed if even one of the env vars is not specified. Those vars shouldn't be optional, and so users know that they have to specify them. This is especially the case when users are upgrading from the older version of the Docker container.

@hung-pelith
Copy link
Contributor

hung-pelith commented Oct 27, 2021

We're attempting to build a new process for it.
It'll approximately be like:

  1. Set up the address of admin in the .env file
  2. A simple dashboard for the admin to edit the clients after login
  3. Only the client name and redirect uri is editable, client id and client secret will be generated by the server

@hung-pelith hung-pelith added the enhancement New feature or request label Oct 27, 2021
@rht
Copy link
Contributor Author

rht commented Oct 28, 2021

If you use a web ui, then the set up process via Docker can no longer be automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants