Calculate s correctly in inversion

penumbra-zone · Jan 12, 2024 · 2750d86 · 2750d86
1 parent ff1d7d8
commit 2750d86
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/src/fields/fp/u32/wrapper.rs b/src/fields/fp/u32/wrapper.rs
@@ -149,7 +149,7 @@ impl Fp {
             f = out2;
         }
 
-        let s = ((f[f.len() - 1] >> 32 - 1) & 1) as u8;
+        let s = ((f[f.len() - 1] >> (32 - 1)) & 1) as u8;
         let mut neg = fiat::FpMontgomeryDomainFieldElement([0; N]);
         fiat::fp_opp(&mut neg, &fiat::FpMontgomeryDomainFieldElement(v));
 

diff --git a/src/fields/fp/u64/wrapper.rs b/src/fields/fp/u64/wrapper.rs
@@ -140,7 +140,7 @@ impl Fp {
             f = out2;
         }
 
-        let s = ((f[f.len() - 1] >> 32 - 1) & 1) as u8;
+        let s = ((f[f.len() - 1] >> (64 - 1)) & 1) as u8;
         let mut neg = fiat::FpMontgomeryDomainFieldElement([0; N]);
         fiat::fp_opp(&mut neg, &fiat::FpMontgomeryDomainFieldElement(v));
 

diff --git a/src/fields/fq/u32/wrapper.rs b/src/fields/fq/u32/wrapper.rs
@@ -149,7 +149,7 @@ impl Fq {
             f = out2;
         }
 
-        let s = ((f[f.len() - 1] >> 32 - 1) & 1) as u8;
+        let s = ((f[f.len() - 1] >> (32 - 1)) & 1) as u8;
         let mut neg = fiat::FqMontgomeryDomainFieldElement([0; N]);
         fiat::fq_opp(&mut neg, &fiat::FqMontgomeryDomainFieldElement(v));
 

diff --git a/src/fields/fq/u64/wrapper.rs b/src/fields/fq/u64/wrapper.rs
@@ -138,7 +138,7 @@ impl Fq {
             f = out2;
         }
 
-        let s = ((f[f.len() - 1] >> 32 - 1) & 1) as u8;
+        let s = ((f[f.len() - 1] >> (64 - 1)) & 1) as u8;
         let mut neg = fiat::FqMontgomeryDomainFieldElement([0; N]);
         fiat::fq_opp(&mut neg, &fiat::FqMontgomeryDomainFieldElement(v));
 

diff --git a/src/fields/fr/u32/wrapper.rs b/src/fields/fr/u32/wrapper.rs
@@ -149,7 +149,7 @@ impl Fr {
             f = out2;
         }
 
-        let s = ((f[f.len() - 1] >> 32 - 1) & 1) as u8;
+        let s = ((f[f.len() - 1] >> (32 - 1)) & 1) as u8;
         let mut neg = fiat::FrMontgomeryDomainFieldElement([0; N]);
         fiat::fr_opp(&mut neg, &fiat::FrMontgomeryDomainFieldElement(v));
 

diff --git a/src/fields/fr/u64/wrapper.rs b/src/fields/fr/u64/wrapper.rs
@@ -138,7 +138,7 @@ impl Fr {
             f = out2;
         }
 
-        let s = ((f[f.len() - 1] >> 32 - 1) & 1) as u8;
+        let s = ((f[f.len() - 1] >> (64 - 1)) & 1) as u8;
         let mut neg = fiat::FrMontgomeryDomainFieldElement([0; N]);
         fiat::fr_opp(&mut neg, &fiat::FrMontgomeryDomainFieldElement(v));