Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pare down vendored proto definitions #102

Open
conorsch opened this issue Jun 5, 2024 · 1 comment
Open

build: pare down vendored proto definitions #102

conorsch opened this issue Jun 5, 2024 · 1 comment

Comments

@conorsch
Copy link
Contributor

conorsch commented Jun 5, 2024

As of #99, we're using vendored proto definitions from the Penumbra monorepo. The initial inclusion of proto defs copied them over from the Penumbra repo. Instead, we should be using the buf-tooling to fetch the info that we need. We also don't need all those protos, like tendermint, ibc, etc. It should be enough to fetch-and-then-vendor only the specific proto defs that we need.

One way to do this is to fetch via buf export and then rm -rf <dir> and dirs we don't care about. See similar logic in:

We could also wire up CI to publish the Galileo protos, but I don't think that's necessary, and would prefer to avoid it until it's must-do for some reason.

@cratelyn
Copy link
Contributor

cratelyn commented Jun 5, 2024

thank you for filing this! i'd love to avoid the need to vendor these, i appreciate your grace in allowing me to be expeditious and hacky 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants