Cherry-pick ci fixes to release/v0.73.x branch #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the cargo-dist dependency, and regenerates the relevant CI files. Tested these changes in a private fork, so we can be confident they won't break builds. Motivated by deprecation warnings in cargo-dist declaring that pinning rust versions should use `rust-toolchain.toml`, updated ours to pin 1.75. Standardizing on the toolchain file lets us remove repeated versions from a few different places, such as the containerbuild. Removed custom action helpers from Rust CI workflows, because GHA runners already come with rustup, and will honor the toolchain file. This change ensures that our dev, build, and test environments all use the same version of rust, which should minimize surprises like we saw in #4231. Included in the release artifacts now is a complete source tarball with associated checksum, as requested in #4195. We're also distributing binaries compressed as .tar.gz, rather than .tar.xz, to satisfy #4256, and opting into a custom install script to satisfy #4255. Therefore: * closes #4195 * closes #4255 * closes #4256 (cherry picked from commit 36280c4) Involved some manual conflict-resolution, particularly around RUSTFLAGS, preserving the overrides since we haven't dropped the requirement for the tokio unstable flag in the release branches yet. ci: fix rust-toolchain.toml in container Follow-up to #4282, ensuring that the rust-toolchain.toml makes it into the container image, otherwise it'll throw an error on image build. Observed this on the post-merge preview deploy. (cherry picked from commit 8d3f4f9)
erwanor
approved these changes
Apr 29, 2024
conorsch
added a commit
that referenced
this pull request
Apr 29, 2024
Refs #4288, #4284. Ports the latest tooling commit to the guide. Updates the installer logic to make use of the new cargo-dist installer scripts, so that macOS instructions are copy/pasteable in the guide (#4255) and use .tar.gz for archive format (#4256). I opted to leave the pd instructions largely as they are.
1 task
conorsch
added a commit
that referenced
this pull request
Apr 30, 2024
Refs #4288, #4284. Ports the latest tooling commit to the guide. Updates the installer logic to make use of the new cargo-dist installer scripts, so that macOS instructions are copy/pasteable in the guide (#4255) and use .tar.gz for archive format (#4256). I opted to leave the pd instructions largely as they are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Ports the CI fixes in #4282 & #4286 to the release branch for the current testnet. Doing this so that today's point release for #4284 will include new build artifacts.
Involved some manual conflict-resolution, particularly around RUSTFLAGS, preserving the overrides since we haven't dropped the requirement for the tokio unstable flag in the release branches yet. Made sure to test the latest copy of the release workflow on a private fork.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: