Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI v2: ActionView component #2053

Open
4 of 26 tasks
Tracked by #1937
VanishMax opened this issue Feb 14, 2025 · 1 comment · Fixed by #2055
Open
4 of 26 tasks
Tracked by #1937

UI v2: ActionView component #2053

VanishMax opened this issue Feb 14, 2025 · 1 comment · Fixed by #2055
Assignees
Labels
ui Related to user interface or ux design V2 features required after mainnet

Comments

@VanishMax
Copy link
Contributor

VanishMax commented Feb 14, 2025

Useful context: https://github.com/penumbra-zone/web/blob/main/docs/adrs/003-action-views.md

Design: https://www.figma.com/design/QSiF2XSvHAWwzBJS5C3f4S/Penumbra-Web-UI?node-id=4-3315&m=dev

@VanishMax VanishMax changed the title Action Views — _(new component)_ (actions ranked P1 highest priority to P4 lowest priority) UI v2: ActionView component Feb 14, 2025
@VanishMax VanishMax self-assigned this Feb 14, 2025
@TalDerei
Copy link
Contributor

TalDerei commented Feb 14, 2025

@VanishMax added ActionLiquidityTournmentVote action view

@TalDerei TalDerei added ui Related to user interface or ux design V2 features required after mainnet labels Feb 16, 2025
VanishMax added a commit that referenced this issue Feb 17, 2025
@VanishMax VanishMax linked a pull request Feb 17, 2025 that will close this issue
VanishMax added a commit that referenced this issue Feb 17, 2025
* fix(ui): #2053: add `smallTechnical` variant to Typography component

* feat(ui): #2053: Add base for the ActionView component

* feat(ui): #2053: Implement Spend and Output action views

* feat(ui): #2053: implement SwapAction view

* feat(ui): #2053: implement opaque views for existing actions

* feat(ui): #2053: create skeleton files for unimplemented actions

* chore: changeset

* fix(ui): #2053: after review
@VanishMax VanishMax reopened this Feb 17, 2025
VanishMax added a commit that referenced this issue Feb 21, 2025
* feat(ui): #2053: implement `SwapClaim` action view

* chore: changeset

* fix(ui): #2053: fix SwapClaim action view

* fix: format
VanishMax added a commit that referenced this issue Feb 21, 2025
…ws-3

# Conflicts:
#	packages/ui/src/ActionView/action-view.tsx
#	packages/ui/src/ActionView/actions/swap-claim.tsx
#	packages/ui/src/ActionView/index.stories.tsx
#	packages/ui/src/ActionView/swap/swap.tsx
#	packages/ui/src/ActionView/types.ts
#	packages/ui/src/utils/bufs/action-view.ts
VanishMax added a commit that referenced this issue Feb 21, 2025
VanishMax added a commit that referenced this issue Feb 24, 2025
* feat(ui): #2053: implement `SwapClaim` action view

* chore: changeset

* fix(ui): #2053: fix SwapClaim action view

* fix: format

* feat(ui): #2053: implement `AssetGroup` component

* feat(ui): improve `AssetGroup` component

* fix(ui): improve `AssetGroup` and `Pill` component

* feat(ui): #2053: implement `PositionOpen` action view

* feat(ui): #2053: implement `PositionClose` action view

* feat(ui): #2053: implement `PositionWithdraw` and `RewardClaim` actions

* chore: changeset

* fix(ui): #2053: fill all actions

* fix(ui): show fees in PositionOpen action view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to user interface or ux design V2 features required after mainnet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants