Extension for SplFileObject (fixed #106) (#112)

Author: pepakriz

extension.neon

@@ -59,6 +59,11 @@ services:
 		tags:
 			- exceptionRules.dynamicConstructorThrowTypeExtension
 
+	-
+		class: Pepakriz\PHPStanExceptionRules\Extension\SplFileObjectExtension
+		tags:
+			- exceptionRules.dynamicConstructorThrowTypeExtension
+
 	-
 		class: Pepakriz\PHPStanExceptionRules\Extension\JsonEncodeDecodeExtension
 		tags:

src/Extension/SplFileObjectExtension.php

@@ -0,0 +1,36 @@
+<?php declare(strict_types = 1);
+
+namespace Pepakriz\PHPStanExceptionRules\Extension;
+
+use LogicException;
+use Pepakriz\PHPStanExceptionRules\DynamicConstructorThrowTypeExtension;
+use Pepakriz\PHPStanExceptionRules\UnsupportedClassException;
+use PhpParser\Node\Expr\New_;
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Type\ObjectType;
+use PHPStan\Type\Type;
+use PHPStan\Type\UnionType;
+use RuntimeException;
+use SplFileObject;
+use function is_a;
+
+class SplFileObjectExtension implements DynamicConstructorThrowTypeExtension
+{
+
+	/**
+	 * @throws UnsupportedClassException
+	 */
+	public function getThrowTypeFromConstructor(MethodReflection $methodReflection, New_ $newNode, Scope $scope): Type
+	{
+		if (is_a($methodReflection->getDeclaringClass()->getName(), SplFileObject::class, true)) {
+			return new UnionType([
+				new ObjectType(RuntimeException::class),
+				new ObjectType(LogicException::class),
+			]);
+		}
+
+		throw new UnsupportedClassException();
+	}
+
+}

tests/src/Rules/PhpInternalsTest.php

@@ -9,6 +9,7 @@
 use Pepakriz\PHPStanExceptionRules\Extension\IntdivExtension;
 use Pepakriz\PHPStanExceptionRules\Extension\JsonEncodeDecodeExtension;
 use Pepakriz\PHPStanExceptionRules\Extension\ReflectionExtension;
+use Pepakriz\PHPStanExceptionRules\Extension\SplFileObjectExtension;
 use Pepakriz\PHPStanExceptionRules\RuleTestCase;
 use PHPStan\Rules\Rule;
 use Throwable;
@@ -23,6 +24,7 @@ protected function getRule(): Rule
 	{
 		$reflectionClassExtension = new ReflectionExtension($this->createBroker());
 		$dateTimeExtension = new DateTimeExtension();
+		$splFileObjectExtension = new SplFileObjectExtension();
 		$jsonEncodeDecodeExtension = new JsonEncodeDecodeExtension();
 		$intdivExtension = new IntdivExtension();
 		return new ThrowsPhpDocRule(
@@ -37,6 +39,7 @@ protected function getRule(): Rule
 				[
 					$reflectionClassExtension,
 					$dateTimeExtension,
+					$splFileObjectExtension,
 				],
 				[
 					$jsonEncodeDecodeExtension,

tests/src/Rules/data/throws-php-internal-functions.php

@@ -10,6 +10,7 @@
 use ReflectionObject;
 use ReflectionProperty;
 use ReflectionZendExtension;
+use SplFileObject;
 use stdClass;
 use Throwable;
 use function rand;
@@ -103,6 +104,11 @@ public function testDateTime(): void
 		new DateTime(rand(0, 1) === 0 ? '2018-01-01' : 123); // error: Missing @throws Exception annotation
 	}
 
+	public function testSplFileObject(): void
+	{
+		new SplFileObject(); // error: Missing @throws LogicException annotation; Missing @throws RuntimeException annotation
+	}
+
 	public function testIntdiv(): void
 	{
 		/** @var int $integer */